Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal: add interpreter support #380842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MisileLab
Copy link
Contributor

@MisileLab MisileLab commented Feb 10, 2025

I think author is inactive, so I made new pull request based on #340760.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@donovanglover
Copy link
Member

Ideally cherry pick so @hissssst is the commit author

@MisileLab
Copy link
Contributor Author

I cherry-picked commit.

@donovanglover
Copy link
Member

Great now can you change the commit message with git commit --amend? Seems okay after that assuming the interpreter works and everything still compiles (I haven't tested it).

@donovanglover
Copy link
Member

Based on crystal-lang/crystal@c2be622 Crystal 1.2 doesn't have the interpreter, so ideally we merge #381772 first to avoid more conditionals

@donovanglover
Copy link
Member

Review failed on x86_64-linux and aarch64-linux due to consuming too many resources but I was able to get the results on Darwin:

x86_64-darwin

⏩ 6 packages marked as broken and skipped:
  • crystal_1_2
  • crystal_1_7
  • crystal_1_8
  • crystal_1_9
  • scry
  • shards_0_17
✅ 27 packages built:
  • ameba
  • amqpcat
  • blahaj
  • crystal (crystal_1_15)
  • crystal.bin (crystal_1_15.bin)
  • crystal.lib (crystal_1_15.lib)
  • crystal2nix
  • crystal_1_11
  • crystal_1_11.bin
  • crystal_1_11.lib
  • crystal_1_12
  • crystal_1_12.bin
  • crystal_1_12.lib
  • crystal_1_14
  • crystal_1_14.bin
  • crystal_1_14.lib
  • crystalline
  • gi-crystal
  • icr
  • invidious
  • kakoune-cr
  • lucky-cli
  • mint
  • oq
  • shards
  • thicket
  • tmuxPlugins.fingers

aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • crystal_1_2
  • crystal_1_7
  • crystal_1_8
  • crystal_1_9
  • scry
  • shards_0_17
❌ 27 packages failed to build:
  • ameba
  • amqpcat
  • blahaj
  • crystal (crystal_1_15)
  • crystal.bin (crystal_1_15.bin)
  • crystal.lib (crystal_1_15.lib)
  • crystal2nix
  • crystal_1_11
  • crystal_1_11.bin
  • crystal_1_11.lib
  • crystal_1_12
  • crystal_1_12.bin
  • crystal_1_12.lib
  • crystal_1_14
  • crystal_1_14.bin
  • crystal_1_14.lib
  • crystalline
  • gi-crystal
  • icr
  • invidious
  • kakoune-cr
  • lucky-cli
  • mint
  • oq
  • shards
  • thicket
  • tmuxPlugins.fingers

Logs: https://github.com/donovanglover/nixpkgs-review-gha/actions/runs/13418227799/job/37484304137#step:6:3998

@SuperSandro2000 SuperSandro2000 mentioned this pull request Feb 19, 2025
13 tasks
@MisileLab
Copy link
Contributor Author

x86_64-linux

⏩ 7 packages marked as broken and skipped:
  • crystal_1_12
  • crystal_1_2
  • crystal_1_7
  • crystal_1_8
  • crystal_1_9
  • scry
  • shards_0_17
✅ 27 packages built:
  • ahk_x11
  • ameba
  • amqpcat
  • blahaj
  • collision
  • crystal (crystal_1_15)
  • crystal.bin (crystal_1_15.bin)
  • crystal.lib (crystal_1_15.lib)
  • crystal2nix
  • crystal_1_11
  • crystal_1_11.bin
  • crystal_1_11.lib
  • crystal_1_14
  • crystal_1_14.bin
  • crystal_1_14.lib
  • crystalline
  • gi-crystal
  • icr
  • invidious
  • kakoune-cr
  • lucky-cli
  • mint
  • oq
  • rtfm
  • shards
  • thicket
  • tmuxPlugins.fingers

log: https://github.com/MisileLab/nixpkgs-review-gha/actions/runs/13430720853/job/37521854029#step:6:1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants