Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Improve gradle section #380165

Merged
merged 1 commit into from
Feb 19, 2025
Merged

doc: Improve gradle section #380165

merged 1 commit into from
Feb 19, 2025

Conversation

Gerg-L
Copy link
Contributor

@Gerg-L Gerg-L commented Feb 7, 2025 •
edited
Loading

  • add makeWrapper to nativeBuildInputs so the example actually works
  • switch the fetchFromGitHub call to using tag
  • use finalAttrs.finalPackage for the mitmCache instead of the existing hack
  • use lib.getExe to get the java binary

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: java Including JDK, tooling, other languages, other VMs 8.has: documentation This PR adds or changes documentation labels Feb 7, 2025
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Feb 8, 2025

I added the first option back, let me know your thoughts @chayleaf

chayleaf
chayleaf reviewed Feb 8, 2025
View reviewed changes
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Feb 9, 2025

Lol, doc workflow broke on a https error...

chayleaf
chayleaf approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@chayleaf chayleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 9, 2025
@kira-bruneau kira-bruneau merged commit e8f3f37 into NixOS:master Feb 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayleaf chayleaf chayleaf approved these changes

@Infinidoge Infinidoge Awaiting requested review from Infinidoge

@tomodachi94 tomodachi94 Awaiting requested review from tomodachi94

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

Assignees
No one assigned
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gerg-L @chayleaf @kira-bruneau @wegank