[Backport release-24.11] cargo-lambda: move to pkgs/by-name, small refactorings #380155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit cf5ff2a)
niklaskorz
commented
Feb 7, 2025
| owner = pname; | ||
| repo = pname; | ||
| rev = "v${version}"; | ||
| hash = "sha256-58kVtwBZEAlv9eVesqmWMZ+KxAwEiGMm8mCf9X5tPMI="; |
There was a problem hiding this comment.
No idea why the hash in 24.11 differed from the one in master
There was a problem hiding this comment.
Verified manually, the previous hash was correct, will restore and double check the hash on master
There was a problem hiding this comment.
Never mind, master is on 1.6.2 and 24.11 on 1.5.0, so this checks out :)
niklaskorz
force-pushed
the
backport-379874-to-release-24.11
branch
from
45a6422 to
40c4716
Compare
|
@matthiasbeyer This backports everything from #379874 except the darwin fix, which isn't necessary on 24.11 as the download test already was completely disabled here, and the second failing test doesn't exist in 1.5.0. Let me know if the update to 1.6.2 should be included in the backport, in which case I will cherry-pick that update as well and include the darwin fix commit again. |
niklaskorz
changed the title
github-actions
bot
added
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
matthiasbeyer
requested changes
Feb 9, 2025
matthiasbeyer
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #379874 with resolved conflicts.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.