glog: patch /usr/bin/true in tests #378903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
reviewed
Feb 2, 2025
|
This PR should target |
SuperSandro2000
changed the title
|
This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people. |
Tests appear to use `/usr/bin/true` as a fake mailer, which causes an error in the check phase. This does not cause the tests to fail, and this is why the replace is a warn and not fail. Patching it nonetheless.
Pleune
force-pushed
the
glog-usr-bin-true
branch
from
4d2a801 to
4f680c2
Compare
github-actions
bot
added
6.topic: python
6.topic: nixos
github-actions
bot
removed
the
6.topic: continuous integration
ofborg
bot
added
2.status: merge conflict
tobim
approved these changes
Feb 3, 2025
|
Thanks both for the informative feedback. I have rebased onto staging and confirmed a good build on my system. I think I have done this in a way to avoid extra pings, so if that is not the case let me know. |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low priority because current checkPhase does not fail. But perhaps in the future this could cause a failure.
Tests appear to use
/usr/bin/trueas a fake mailer, which causes an error in the check phase. This does not cause the tests to fail, and this is why the replace is a warn and not fail. Patching it nonetheless.In fact, I only saw the error because that test failed when other constraints on my system caused the logging tests to fail, and print more verbose output.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.