Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goose-cli: init at 1.0.4 #378111

Merged
merged 2 commits into from
Feb 3, 2025
Merged

goose-cli: init at 1.0.4 #378111

merged 2 commits into from
Feb 3, 2025

Conversation

nayeko
Copy link
Contributor

@nayeko nayeko commented Jan 30, 2025

an open-source, extensible AI agent that goes beyond code suggestions - install, execute, edit, and test with any LLM. https://github.com/block/goose
part of #378090

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor

sarahec commented Jan 30, 2025

You're pushing quite a few changes. Is this ready for review or should it be a draft?

@nayeko
Copy link
Contributor Author

nayeko commented Jan 30, 2025

ready for review

now ready for review

@nayeko nayeko force-pushed the goose-cli branch 2 times, most recently from 790ca16 to 470aee7 Compare February 1, 2025 22:22
@nayeko nayeko changed the title goose-cli: init at 1.0.2 goose-cli: init at 1.0.4 Feb 1, 2025
@fusion44 fusion44 mentioned this pull request Feb 2, 2025
@sarahec
Copy link
Contributor

sarahec commented Feb 2, 2025

@ofborg build

@sarahec
Copy link
Contributor

sarahec commented Feb 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378111


x86_64-linux

❌ 1 package failed to build:
  • goose-cli

@sarahec
Copy link
Contributor

sarahec commented Feb 2, 2025

That one test failure:

---- developer::tests::test_text_editor_write_and_view_file stdout ----
thread 'developer::tests::test_text_editor_write_and_view_file' panicked at crates/goose-mcp/src/developer/mod.rs:159:43:
should have a current working dir: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

It's not liking the nix sandbox. Since it's only one test, I wouldn't try to give it a working directory for that one, I would just disable it.

@sarahec
Copy link
Contributor

sarahec commented Feb 2, 2025

I forgot to say -- thank you! I'm looking forward to using this.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 2, 2025
@sarahec
Copy link
Contributor

sarahec commented Feb 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378111


x86_64-linux

✅ 1 package built:
  • goose-cli

Copy link
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about the license needing to be "unfree", but that's not enough to stop approval.

pkgs/by-name/go/goose-cli/package.nix Show resolved Hide resolved
pkgs/by-name/go/goose-cli/package.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
@nayeko
Copy link
Contributor Author

nayeko commented Feb 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378111


x86_64-linux

✅ 1 package built:
  • goose-cli

@sarahec
Copy link
Contributor

sarahec commented Feb 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378111


aarch64-darwin

❌ 1 package failed to build:
  • goose-cli

@sarahec
Copy link
Contributor

sarahec commented Feb 3, 2025

   > failures:
   >
   > ---- developer::tests::test_text_editor_undo_edit stdout ----
   > thread 'developer::tests::test_text_editor_undo_edit' panicked at crates/goose-mcp/src/developer/mod.rs:159:43:
   > should have a current working dir: Os { code: 2, kind: NotFound, message: "No such file or directory" }
   > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   >
   > ---- developer::tests::test_text_editor_write_and_view_file stdout ----
   > thread 'developer::tests::test_text_editor_write_and_view_file' panicked at crates/goose-mcp/src/developer/mod.rs:159:43:
   > should have a current working dir: Os { code: 2, kind: NotFound, message: "No such file or directory" }
   >
   >
   > failures:
   >     developer::tests::test_text_editor_undo_edit
   >     developer::tests::test_text_editor_write_and_view_file
   >
   > test result: FAILED. 5 passed; 2 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.01s

@sarahec sarahec self-requested a review February 3, 2025 02:38
Copy link
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, two tests are failing on Darwin (sandbox == true)

pkgs/by-name/go/goose-cli/package.nix Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378111


x86_64-linux

✅ 1 package built:
  • goose-cli

aarch64-linux

✅ 1 package built:
  • goose-cli

x86_64-darwin

✅ 1 package built:
  • goose-cli

aarch64-darwin

✅ 1 package built:
  • goose-cli

@GaetanLepage GaetanLepage merged commit c5ac9d2 into NixOS:master Feb 3, 2025
26 of 28 checks passed
@nayeko nayeko deleted the goose-cli branch February 3, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants