Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpt4all: 3.4.2 -> 3.9.0 #372723

Merged
merged 5 commits into from
Feb 7, 2025
Merged

gpt4all: 3.4.2 -> 3.9.0 #372723

merged 5 commits into from
Feb 7, 2025
+190 −17

Conversation

Titaniumtown
Copy link
Contributor

@Titaniumtown Titaniumtown commented Jan 10, 2025 •
edited
Loading

Had to init these packages as they are new dependencies to gpt4all:
variant-lite
optional-lite
string-view-lite
duckx

Updated gpt4all to 3.9.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from polygon January 10, 2025 18:45
@Titaniumtown
Copy link
Contributor Author

If anyone is eyeing this PR. Feel free to take a stab at the variant-lite issue. I cannot figure it out and I'm busy.

@Titaniumtown Titaniumtown mentioned this pull request Jan 23, 2025
Open
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jan 23, 2025
@Titaniumtown Titaniumtown force-pushed the gpt4all/3.6.1 branch 2 times, most recently from ca23d08 to a9f0f60 Compare January 23, 2025 16:55
@github-actions github-actions bot added 6.topic: python and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jan 23, 2025
@Titaniumtown
Copy link
Contributor Author

oh no my git history is all messed up :p

@Titaniumtown
Copy link
Contributor Author

there we are, git history all fixed

@Titaniumtown Titaniumtown changed the title gpt4all: 3.4.2 -> 3.6.1 gpt4all: 3.4.2 -> 3.7.0 Jan 23, 2025
@Titaniumtown Titaniumtown force-pushed the gpt4all/3.6.1 branch 2 times, most recently from 051b368 to b927eff Compare February 6, 2025 02:15
@Titaniumtown Titaniumtown changed the title gpt4all: 3.4.2 -> 3.7.0 gpt4all: 3.4.2 -> 3.9.0 Feb 6, 2025
@Titaniumtown
Copy link
Contributor Author

It actually builds and works now!

@Titaniumtown Titaniumtown marked this pull request as ready for review February 6, 2025 02:46
@Titaniumtown
Copy link
Contributor Author

Only possible issue is that I've added a few new packages. I may have to split that off into other PRs, but that's a lot of work. So hopefully that's not required haha.

GaetanLepage
GaetanLepage reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR :)

Here is a first batch of comments.

pkgs/by-name/du/duckx/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/du/duckx/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/du/duckx/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/du/duckx/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gp/gpt4all/duckx-fix.patch Outdated Show resolved Hide resolved
pkgs/by-name/va/variant-lite/package.nix Show resolved Hide resolved
pkgs/by-name/st/string-view-lite/package.nix Show resolved Hide resolved
pkgs/by-name/op/optional-lite/package.nix Show resolved Hide resolved
pkgs/by-name/ji/jinja2cpp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/du/duckx/package.nix Show resolved Hide resolved
@Titaniumtown
Copy link
Contributor Author

@GaetanLepage Thanks for the review! I'll go through these comments hopefully today. Very appreciated.

@Titaniumtown Titaniumtown force-pushed the gpt4all/3.6.1 branch 2 times, most recently from 83e7b90 to 8534cd1 Compare February 6, 2025 16:05
@Titaniumtown
Copy link
Contributor Author

Resolved all comments.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372723

x86_64-linux

❌ 3 packages failed to build:
  • gpt4all
  • gpt4all-cuda
  • jinja2cpp
✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

aarch64-linux

❌ 3 packages failed to build:
  • gpt4all
  • gpt4all-cuda
  • jinja2cpp
✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

x86_64-darwin

❌ 1 package failed to build:
  • jinja2cpp
✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

aarch64-darwin

❌ 1 package failed to build:
  • jinja2cpp
✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

@Titaniumtown Titaniumtown force-pushed the gpt4all/3.6.1 branch 3 times, most recently from e722e62 to 34d57ed Compare February 7, 2025 00:31
@Titaniumtown
Copy link
Contributor Author

Ended up removing jinja2cpp... gpt4all... doesn't seem to need it to compile 🤨 ???

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372723

x86_64-linux

❌ 2 packages failed to build:
  • gpt4all
  • gpt4all-cuda
✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

aarch64-linux

❌ 2 packages failed to build:
  • gpt4all
  • gpt4all-cuda
✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

x86_64-darwin

✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

aarch64-darwin

✅ 4 packages built:
  • duckx
  • optional-lite
  • string-view-lite
  • variant-lite

@GaetanLepage
Copy link
Contributor

Here are the cuda logs: https://paste.glepage.com/raw/fish-viper-eagle

@Titaniumtown
Copy link
Contributor Author

Super weird as it builds on my machine (x86_64-linux) I'll start digging into the issue.

@Titaniumtown
Copy link
Contributor Author

Ended up removing jinja2cpp... gpt4all... doesn't seem to need it to compile 🤨 ???

This is why: nomic-ai/gpt4all@f914ee5

@Titaniumtown Titaniumtown mentioned this pull request Feb 7, 2025
Open
@Titaniumtown
Copy link
Contributor Author

Build is fixed, had to disable Kompute/Vulkan support. It didn't work either way as-per: #298997

GaetanLepage
GaetanLepage approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job !

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372723

x86_64-linux

✅ 6 packages built:
  • duckx
  • gpt4all
  • gpt4all-cuda
  • optional-lite
  • string-view-lite
  • variant-lite

aarch64-linux

✅ 6 packages built:
  • duckx
  • gpt4all
  • gpt4all-cuda
  • optional-lite
  • string-view-lite
  • variant-lite

@GaetanLepage GaetanLepage merged commit c08ad8f into NixOS:master Feb 7, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@polygon polygon Awaiting requested review from polygon

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Titaniumtown @GaetanLepage