Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luarocks: enable for freebsd and if native net/openbsd #369706

Closed
wants to merge 1 commit into from
Closed

luarocks: enable for freebsd and if native net/openbsd #369706

wants to merge 1 commit into from

Conversation

ArchercatNEO
Copy link
Contributor

I tried to cross-compile neovim for x86_64-freebsd and discovered this package only supports linux/darwin.
FreeBSD ports does have luarocks though so I assume there must not be any incompatibility.
Looking back through the git history the initial commit was linux-only then darwin was enabled, without justification of why other platforms are disabled.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ArchercatNEO ArchercatNEO force-pushed the luarocks-cross-compile branch from a06a7b5 to b7b473d Compare December 31, 2024 15:59
@ArchercatNEO ArchercatNEO changed the title luarocks: enable for all platforms luarocks: enable for unix-like platforms Dec 31, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 31, 2024
@teto
Copy link
Member

teto commented Dec 31, 2024

do you want to add yourself as a maintainer ?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 1, 2025
@teto
Copy link
Member

teto commented Feb 4, 2025

@ArchercatNEO have you managed to cross-compile so we can merge ?

@PerchunPak
Copy link
Member

Well, pkgsCross.x86_64-freebsd.neovim fails with Package ‘libmpack-1.0.5’ is not available on the requested hostPlatform

@ArchercatNEO
Copy link
Contributor Author

Luarocks cross-compiles for freebsd but for both netbsd and openbsd fail as python is not supported on them

@teto
Copy link
Member

teto commented Feb 5, 2025

why would a faliled python block luarocks ?

I have no problem enabling luarocks for BSD on the contrary the more the better but if it justs adds a broken package to BSD then the tradeoff is not good. I wish this PR could actually make luarocks build for BSD

@ArchercatNEO
Copy link
Contributor Author

Not sure where in transitive dependencies python gets pulled in but running with the allow unsupported flag will try to compile python but fail in configure.

Very interestingly python has a patch specifically so that the configure accepts x86_64-freebsd but not any other bsd. I'll see if just adding net/openbsd to the patch leads to further errors or can be done safely

@ArchercatNEO
Copy link
Contributor Author

Nope seems like python only cross-compiles for freebsd and not open/net (and I'd say making a patch large enough to fix the configure.ac unwise) so unless luarocks has a redundant dependency on python we can't enable it for all the bsds. I could always just amend it again to enable specifically freebsd and not the other bsds.

@ArchercatNEO ArchercatNEO force-pushed the luarocks-cross-compile branch from b7b473d to 89000b0 Compare February 5, 2025 19:41
@ArchercatNEO ArchercatNEO changed the title luarocks: enable for unix-like platforms luarocks: enable for freebsd and if native net/openbsd Feb 5, 2025
@ArchercatNEO ArchercatNEO force-pushed the luarocks-cross-compile branch from 89000b0 to d46dc5b Compare February 5, 2025 19:44
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 5, 2025
@ArchercatNEO ArchercatNEO force-pushed the luarocks-cross-compile branch from d46dc5b to 68a6f8e Compare February 5, 2025 20:11
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust 6.topic: vim 6.topic: erlang 6.topic: ocaml 6.topic: xfce The Xfce Desktop Environment labels Feb 5, 2025
@github-actions github-actions bot added 6.topic: nodejs 6.topic: pantheon The Pantheon desktop environment 6.topic: testing Tooling for automated testing of packages and modules 6.topic: systemd 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: cuda Parallel computing platform and API 6.topic: vscode 6.topic: lib The Nixpkgs function library 6.topic: zig 6.topic: games 6.topic: php 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: deepin Desktop environment and its components 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 8.has: documentation This PR adds or changes documentation 6.topic: policy discussion backport release-24.11 Backport PR automatically labels Feb 5, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 5, 2025
@ArchercatNEO
Copy link
Contributor Author

Sorry for all the pings enabling freebsd does not seem worth this much effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: cuda Parallel computing platform and API 6.topic: deepin Desktop environment and its components 6.topic: dotnet Language: .NET 6.topic: erlang 6.topic: games 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 6.topic: ocaml 6.topic: pantheon The Pantheon desktop environment 6.topic: php 6.topic: policy discussion 6.topic: python 6.topic: rust 6.topic: systemd 6.topic: testing Tooling for automated testing of packages and modules 6.topic: vim 6.topic: vscode 6.topic: xfce The Xfce Desktop Environment 6.topic: zig 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
CUDA Team
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArchercatNEO @teto @PerchunPak @wegank