python3Packages.pastescript: remove nose dependency #327246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses NixOS#326513. Dependency nose was removed in version 3.3.0 (2023-01-03). Replaced `format` parameter with `pyproject = true` and `build-system` set to `setuptools`
lavafroth
force-pushed
the
python3Packages.pastescript/nose
branch
from
5a001db
to
e426922
Compare
|
@ofborg build python3Packages.pastescript |
emilazy
reviewed
Jul 15, 2024
Comment on lines
34
to
+37
| # test suite seems to unset PYTHONPATH | ||
| doCheck = false; | ||
|
|
||
| nativeCheckInputs = [ | ||
| nose | ||
| pytestCheckHook | ||
| ]; | ||
| nativeCheckInputs = [ pytestCheckHook ]; |
There was a problem hiding this comment.
The tests are still broken, I guess?
There was a problem hiding this comment.
Yes. The package exports its namespace as paste which clobbers the pre-existing dependency with the same name.
There was a problem hiding this comment.
pastedeploy does something similar but its tests pass. Probably the use of the deprecated pkg_resources is causing the issue? Anyways, it's not something we should try to fix.
emilazy
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Addresses #326513.
Dependency nose was removed in version 3.3.0 (2023-01-03). Replaced
formatparameter withpyproject = trueandbuild-systemset tosetuptools.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.