Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake-lint: remove nose dependency #327220

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 14, 2024

Description of changes

Removes a dependency on nose, part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions about the coverage testing (is there an obstacle to just running the unmodified test suite?) but this looks good to me; upstream doesn’t mention nose at all any more. I wonder how many totally unused Python dependencies we have in tree…

@pyrox0
Copy link
Member Author

pyrox0 commented Jul 15, 2024

No strong opinions about the coverage testing (is there an obstacle to just running the unmodified test suite?) but this looks good to me; upstream doesn’t mention nose at all any more. I wonder how many totally unused Python dependencies we have in tree…

There's no obstacle(afaik) to running it besides adding the pytest-cov dependency to nativeCheckInputs, it's just not useful to run them in Nix checks.

@emilazy
Copy link
Member

emilazy commented Jul 15, 2024

I’d personally be willing to spend a build dependency and some CPU cycles to avoid the churn of a patch that might rot and block updates, but you’re right that it is kind of pointless to run. I’ll leave it to the maintainer’s discretion :)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 15, 2024
@Aleksanaa Aleksanaa merged commit ae9c93b into NixOS:master Jul 24, 2024
32 checks passed
@pyrox0 pyrox0 deleted the denose/cmake-lint branch August 4, 2024 23:21
@SuperSandro2000
Copy link
Member

It is guidance by the python people that pytest-cov (like all other linters and the like) is not to be used and be patched our or now be replaced with pytest-cov-stub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants