-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update daisyui to v5 #4
Draft
Nittarab
wants to merge
21
commits into
main
Choose a base branch
from
update-daisyui-to-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and DaisyUI Integration (#5) This PR significantly expands and refines the DaisyComponents library, introducing new components, enhancing existing ones, and improving testing/preview infrastructure. Critically, it introduces a method to copy previews directly from DaisyUI, ensuring component correctness and accelerating development, supported by new tests that validate all previews. - New Components: - `DividerComponent`: Provides a visual separator. - `ItemComponent`: Standardizes list item display. - `TitleComponent`: Ensures consistent title styling. - Component Enhancements: - `ButtonComponent`: New color options, sizes, variants (ghost, link, outline, soft), shapes (square, circle), loading states, and HTML tag flexibility. - `DropdownComponent`: Improved alignment, hover functionality, custom trigger, menu classes, and tab index control. - Testing and Preview Improvements: - Added `PreviewTestConcern` to streamline testing of preview. - Comprehensive updates to component previews (Lookbook), **now including the ability to directly copy previews from DaisyUI, ensuring visual accuracy and accelerating development.** - Extensive test coverage, **including new tests that automatically validate all preview examples.** - Added fixtures. - Build and Configuration: - Updated Rubocop configuration. - Added VS Code configurations. - Included `ruby-lsp-rails` gem. - Updated dependencies. - Iconography - Added `IconHelper`. - Documentation: - Added a Ruby script to scrape component examples. - Fixes - The dropdown component now uses unique names for popover and anchor ## Review instruction Run `COVERAGE=true bin/rails test` to check the coverage. Check the preview with Lookbook.
improvement and tests Card 2 DRY build argument Fix card componets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.