Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daisyui to v5 #4

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Update daisyui to v5 #4

wants to merge 21 commits into from

Conversation

Nittarab
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 94.62366% with 30 lines in your changes missing coverage. Please review.

Project coverage is 95.32%. Comparing base (8c7e6b8) to head (0a80611).

Files with missing lines Patch % Lines
...y_components/actions/dropdown_component_preview.rb 88.00% 9 Missing ⚠️
...onents/data_display/accordion_component_preview.rb 82.05% 7 Missing ⚠️
...s/data_display/card_component/actions_component.rb 89.47% 2 Missing ⚠️
...omponents/data_display/avatar_component_preview.rb 85.71% 2 Missing ⚠️
...nts/data_display/avatar_group_component_preview.rb 85.71% 2 Missing ⚠️
...components/data_display/badge_component_preview.rb 88.23% 2 Missing ⚠️
app/components/daisy_components/base_component.rb 80.00% 1 Missing ⚠️
...ents/data_display/card_component/body_component.rb 95.83% 1 Missing ⚠️
...p/components/daisy_components/divider_component.rb 75.00% 1 Missing ⚠️
app/components/daisy_components/item_component.rb 90.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   99.34%   95.32%   -4.02%     
==========================================
  Files          35       38       +3     
  Lines        1516      835     -681     
  Branches       59       79      +20     
==========================================
- Hits         1506      796     -710     
- Misses         10       39      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…and DaisyUI Integration (#5)

This PR significantly expands and refines the DaisyComponents library,
introducing new components, enhancing existing ones, and improving
testing/preview infrastructure. Critically, it introduces a method to
copy previews directly from DaisyUI, ensuring component correctness and
accelerating development, supported by new tests that validate all
previews.

- New Components:
    -   `DividerComponent`: Provides a visual separator.
    -   `ItemComponent`: Standardizes list item display.
    -   `TitleComponent`: Ensures consistent title styling.

- Component Enhancements:
- `ButtonComponent`: New color options, sizes, variants (ghost, link,
outline, soft), shapes (square, circle), loading states, and HTML tag
flexibility.
- `DropdownComponent`: Improved alignment, hover functionality, custom
trigger, menu classes, and tab index control.


- Testing and Preview Improvements:
    - Added `PreviewTestConcern` to streamline testing of preview.
- Comprehensive updates to component previews (Lookbook), **now
including the ability to directly copy previews from DaisyUI, ensuring
visual accuracy and accelerating development.**
- Extensive test coverage, **including new tests that automatically
validate all preview examples.**
    - Added fixtures.

- Build and Configuration:
    - Updated Rubocop configuration.
    - Added VS Code configurations.
    - Included `ruby-lsp-rails` gem.
    - Updated dependencies.

- Iconography
    - Added `IconHelper`.

- Documentation:
  - Added a Ruby script to scrape component examples.

- Fixes
  - The dropdown component now uses unique names for popover and anchor

## Review instruction

Run `COVERAGE=true bin/rails test` to check the coverage.
Check the preview with Lookbook.
improvement and tests

Card 2

DRY build argument

Fix card componets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant