Component Library Updates and Enhancements #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the CardComponent to support a simpler, more direct API while maintaining backwards compatibility: - Add direct props for title, description, button_text, button_class, and image_url - Auto-render figure and body components when props are provided - Delegate props from card to nested components - Update tests to cover new functionality - Simplify preview examples using new direct props - Maintain slot-based API as override option This change reduces boilerplate while keeping the flexibility of the slot-based API.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
===========================================
- Coverage 100.00% 99.34% -0.66%
===========================================
Files 15 35 +20
Lines 284 1516 +1232
Branches 24 59 +35
===========================================
+ Hits 284 1506 +1222
- Misses 0 10 +10 ☔ View full report in Codecov by Sentry. |
fix avatar html Improve placeholder
Fix component Improve test Improvements
Fix Dropdown component
- Added `html_attributes` method to components for better handling of HTML attributes - Updated components to use `tag.div(**html_attributes)` pattern - Added tests for HTML attributes handling in: - AccordionComponent - AccordionItemComponent - AvatarComponent - AvatarGroupComponent - BadgeComponent - CardComponent - Card::ActionsComponent - Added coverage report parsing script - Added development dependencies for coverage reporting
Nittarab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several updates and enhancements to the component library, focusing on improved functionality, testing, and documentation. Key changes include:
icon_startandicon_endparametershtml_attributeshandling