Added FreeBSD aarch64 (ARM64) support #218
Conversation
| if(OSUtil.isARM()) { | ||
| if(OSUtil.is64Bit()) { |
There was a problem hiding this comment.
Could just be
| if(OSUtil.isARM()) { | |
| if(OSUtil.is64Bit()) { | |
| if(OSUtil.isARM() && OSUtil.is64Bit()) { |
There was a problem hiding this comment.
Thank you for your contribution! This looks good. As noted below, can you confirm that the -m64 flag is strictly necessary? Then I'm happy to merge.
My biggest reservation is that native libraries for all of the other supported platforms can be cross-compiled, and there's no off-the-shelf cross-compiler to target FreeBSD arm64 from Linux amd64. However, the actual build process integrates cleanly with the others, and it looks possible to extend the current FreeBSD cross-compilation environment to support arm64, so I'm happy to accept this as un-CI'd for now with the expectation that I'll be able to add it to CI later.
src/main/c/Makefile
Outdated
| freebsdarm64v8: export CFLAGS += -I$(JAVA_HOME)/include/freebsd -m64 | ||
| freebsdarm64v8: export LDFLAGS += -m64 |
There was a problem hiding this comment.
I think the -m64 flag is AMD64-specific, and I suspect it's ignored outright when building for AArch64. Have you tried without the flag to confirm it's necessary, or if not, can you please do so?
There was a problem hiding this comment.
Your right! I missed that one. I have removed the flag and verified the resulting binary still works.
siepkes
force-pushed
the
freebsd-aarch64
branch
2 times, most recently
from
96434ac to
c7affa3
Compare
|
Thanks for the prompt review! I've addressed your feedback. On closer inspection I also noticed I needed to add the variant in the makefile so the resulting binary has the correct name. You might already know about it but there is also the Maven NAR plugin to aid in dealing with native code. |
src/main/c/Makefile
Outdated
| @@ -239,6 +239,13 @@ freebsd64: export platform := freebsd/x86_64 | |||
| freebsd64: | |||
| $(MAKE) -f natives.mk | |||
|
|
|||
| # Requires a FreeBSD host running on aarch64 (arm64) architecture. | |||
| freebsdarm64v8: export CFLAGS += -I$(JAVA_HOME)/include/freebsd -m64 | |||
There was a problem hiding this comment.
You've removed the -m64 linker flag; did you try without the compiler one, too?
There was a problem hiding this comment.
Sorry, I totally missed the compiler flag. I either need more caffeine or more vacation it seems ;-)
|
Alright, took some tries but I think we've got there! Thanks for your patience! Building with the |
Tested on a Raspberry Pi 4.