Fixed array logic for Get-SQLServerLoginDefaultPw #85
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced with original iteration PR to handle multiple credentials: #44
Same effect as #82 version just uses a subexpression to ensure an array of objects is created.
When generating a matching table with
Where-Object { $_.instance -eq "$TargetInstance"}
, the script assumes it will always return an array of objects, which is not true if there's only one matching instance name, so the iteration and resulting login test will never run.Further, the iteration over the table incorrectly accesses the
username
andpassword
fields, so the resulting login check fails because it instead iterates through the string instead of the array.The change adds a
@()
subexpression to ensure the$TblResultsTemp
is an iteratable collection and moves the element access from$TblResultsTemp.username[$i]
toTblResultsTemp[$i].username
(same for password field).