add option for persistent recent section #1688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additionally tidied up on the logic for show_recent
| @@ -404,6 +404,16 @@ describe("Neogit config", function() | |||
| assert.True(vim.tbl_count(require("neogit.config").validate_config()) ~= 0) | |||
| end) | |||
|
|
|||
| it("should return invalid when sections.recent.hidden isn't a boolean", function() | |||
| config.values.sections.recent.hidden = "not a boolean" | |||
| assert.True(vim.tbl_count(require("neogit.config").validate_config()) ~= 0) | |||
There was a problem hiding this comment.
Added the additional test for the hidden. I'm unsure why this results to true, even the the default config is false
|
I didn't find a documentation section, where I could provide additional context for the option or the current behavior. Happy to add this, if you can point me to somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1687
This PR adds a new option
config.sections.recent.always, which defaults tofalse. This keeps the current behavior which only shows the recent section if there is no unmerged commits. which looks like thisSetting this option to
truewill always show the recent section. which looks like this