-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize translations with Lokalise #1760
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
=========================================
Coverage 70.94% 70.94%
Complexity 1650 1650
=========================================
Files 33 33
Lines 4330 4330
=========================================
Hits 3072 3072
Misses 1258 1258 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checked out the wiki documentation, Lokalise project on their website, and tested out extracting translations locally from Lokalise. Great success!
Reasons for creating this PR
We haven't yet started using Lokalise in daily work, so some of the translations in Lokalise didn't match what we have in the Skosmos code base or vice versa. This PR, together with changes done in Lokalise itself, should bring them in sync.
I have also updated the wiki page Translations for Skosmos 3 with more specific instructions about how to use Lokalise to manage translations and how to do push and pull operations in different situations.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
There were some translations in our messages.XX.json files for many languages (e.g. de, lv, es, fa) that for some reason didn't exist on the Lokalise side. I tried many times to push these to Lokalise using the translations:push command. The command seemed to work, but the translations didn't actually end up in Lokalise. In the end I uploaded those files in the Lokalise UI. That worked. It was (hopefully) a one off operation that doesn't have to be done again... 🤞
Checklist
.sr-only
class, color contrast)