Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize translations with Lokalise #1760

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

osma
Copy link
Member

@osma osma commented Jan 30, 2025

Reasons for creating this PR

We haven't yet started using Lokalise in daily work, so some of the translations in Lokalise didn't match what we have in the Skosmos code base or vice versa. This PR, together with changes done in Lokalise itself, should bring them in sync.

I have also updated the wiki page Translations for Skosmos 3 with more specific instructions about how to use Lokalise to manage translations and how to do push and pull operations in different situations.

Link to relevant issue(s), if any

Description of the changes in this PR

  • remove unnecessary translations for yso-meta classes
  • sync fi/sv/se/en translations with the current state in Lokalise
  • fix a Cypress test that broke due to a changed translated

Known problems or uncertainties in this PR

There were some translations in our messages.XX.json files for many languages (e.g. de, lv, es, fa) that for some reason didn't exist on the Lokalise side. I tried many times to push these to Lokalise using the translations:push command. The command seemed to work, but the translations didn't actually end up in Lokalise. In the end I uploaded those files in the Lokalise UI. That worked. It was (hopefully) a one off operation that doesn't have to be done again... 🤞

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Jan 30, 2025
@osma osma self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.94%. Comparing base (53aa787) to head (fa7fe98).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1760   +/-   ##
=========================================
  Coverage     70.94%   70.94%           
  Complexity     1650     1650           
=========================================
  Files            33       33           
  Lines          4330     4330           
=========================================
  Hits           3072     3072           
  Misses         1258     1258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma marked this pull request as ready for review January 30, 2025 13:57
@osma osma changed the title Synchronize translations with lokalise Synchronize translations with Lokalise Jan 30, 2025
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checked out the wiki documentation, Lokalise project on their website, and tested out extracting translations locally from Lokalise. Great success!

@osma osma merged commit 1a2121a into main Jan 30, 2025
11 checks passed
@osma osma deleted the issue1712-sync-translations-with-lokalise branch January 30, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

2 participants