Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[features/run] Parse primitive types #2733

Merged
merged 10 commits into from
Mar 20, 2025
Merged

[features/run] Parse primitive types #2733

merged 10 commits into from
Mar 20, 2025
+259 −28

Conversation

khalatepradnya
Copy link
Collaborator

Not covered: arrays, tuples

github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
@cuda-quantum-bot
Docs preview for PR #2733.
ef7e760
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
@cuda-quantum-bot
Docs preview for PR #2733.
36dadea
schweitzpgi
schweitzpgi reviewed Mar 14, 2025
View reviewed changes
github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
@cuda-quantum-bot
Docs preview for PR #2733.
4fe8d7d
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@schweitzpgi
Copy link
Collaborator

schweitzpgi commented Mar 20, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

khalatepradnya and others added 10 commits March 20, 2025 12:40
@khalatepradnya @schweitzpgi
* Skeleton for output record logging and parsing

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
19a566b 
  -- primitive types
TODO: Handle arrays (vector of results)

* Naive way of parsing integer array log

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya @schweitzpgi
* More tests - labeled arrays, multiple shots, failing test for tuple

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
3d3805d 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya @schweitzpgi
* Clean-up: Removed the logger functionality since the API was implem…

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
88cd580 
…ented for

testing only
* Addressing PR comment

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya @schweitzpgi
* Fix the format of array label - <type x size>

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
d44fb76 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya @schweitzpgi
* Build fix - back to working stage.

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
a48225a 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya @schweitzpgi
WIP: Using the new interface for parser

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
5fffb4c 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya @schweitzpgi
* Handle primitive types

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
2270ea8 
* Updated tests

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya @schweitzpgi
* Fix test, add "qir-api" to attributes

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
4ddd4ff 
Signed-off-by: Pradnya Khalate <[email protected]>
@schweitzpgi
Update runtime/common/RecordLogDecoder.h

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
861846d 
Signed-off-by: Eric Schweitz <[email protected]>
@schweitzpgi
review comments

Verified

This commit was signed with the committer’s verified signature.
schweitzpgi Eric Schweitz
SSH Key Fingerprint: fcTd+Hr7NM108QM1FP0mKgIn36KruWcHgAEid187tMU
Verified
Learn about vigilant mode
Loading
Loading status checks…
6d08205 
Signed-off-by: Eric Schweitz <[email protected]>
@schweitzpgi schweitzpgi merged commit b25c6bc into NVIDIA:features/run Mar 20, 2025
21 of 25 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 20, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2733.
6cb23f5
@khalatepradnya khalatepradnya deleted the recordLogDecode branch March 25, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schweitzpgi schweitzpgi

@annagrin annagrin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khalatepradnya @schweitzpgi