Explicitly state which extension uses cpp files #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
vzhurba01
changed the title
vzhurba01
changed the title
Each cpp file is only used by a single extension
vzhurba01
force-pushed
the
resolve-parallel-builds
branch
from
5370db7 to
8620a28
Compare
|
/ok to test |
leofang
approved these changes
Jan 8, 2025
|
Let me rerun the CI one more time and see if we could still trigger the flaky builds. |
|
/ok to test |
leofang
added
bug
|
Seems like it works. Let's merge and keep an eye on it. Thanks, Vlad! |
|
Looks like all builds passed. Merging. Thanks! |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since each cpp is only used by a single extension, a simple solution is to expand the regex pattern and specify which extension uses it directly. Both private and utils have limited number of pyx files and therefore this regex expansion doesn't bloat either.
close #271