Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full CI support for public builds + switch to use cibuildwheel #267

Merged
merged 65 commits into from
Dec 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
0141cbf
switch to cibuildwheel + some cleanups
leofang Dec 5, 2024
79fd67a
try setting up Python manually
leofang Dec 5, 2024
92283dc
comment out un-needed code + propagate python-version
leofang Dec 5, 2024
6666e90
fix: need to check out first
leofang Dec 5, 2024
c96fef3
only build natively; add -v; ensure targeting manylinux
leofang Dec 5, 2024
ea77572
single quotes
leofang Dec 5, 2024
508a126
restore env setup to get artifact dir
leofang Dec 5, 2024
beff50d
fix artifact dir
leofang Dec 5, 2024
a935da2
fix artifact name
leofang Dec 5, 2024
df982e5
restore & fix artifact name again
leofang Dec 5, 2024
426cd58
build on all platforms!
leofang Dec 5, 2024
d167a55
fix CIBW_BUILD for windows
leofang Dec 5, 2024
9cd0803
fix typo
leofang Dec 5, 2024
261b1e5
no quotes for wildcard matching
leofang Dec 5, 2024
9134f89
move CIBW_BUILD logic to script
leofang Dec 5, 2024
762ad76
fix win runner name
leofang Dec 5, 2024
0d3c32b
try to find where pwsh is
leofang Dec 5, 2024
37006e8
try to escape
leofang Dec 5, 2024
0ab5067
continue hunting..
leofang Dec 5, 2024
d42f8dd
try to overwrite shell
leofang Dec 5, 2024
55c0370
try to install ps
leofang Dec 5, 2024
f3356f4
be explicit about shell (why?)
leofang Dec 5, 2024
5480f10
only build for win 64 bits
leofang Dec 5, 2024
4b1a431
try to install msvc
leofang Dec 5, 2024
7044c8b
install msvc ourselves
leofang Dec 5, 2024
9fbdff2
fix typo
leofang Dec 5, 2024
8f77f17
skip custom cl ver check
leofang Dec 5, 2024
29e9e2e
install to standard location
leofang Dec 5, 2024
e2cffce
try to locate Python include path
leofang Dec 5, 2024
a7157b5
switch to public windows runner for now
leofang Dec 5, 2024
965b23f
windows image does not have sudo
leofang Dec 5, 2024
8ae7bd2
pwd on Windows Bash does not use Windows path format
leofang Dec 5, 2024
2175ccb
cover all Python versions!
leofang Dec 5, 2024
50eb0e7
add quotes
leofang Dec 5, 2024
b0046ac
align the python version installed via GHA vs used at build time
leofang Dec 5, 2024
4932667
fix constraint syntax
leofang Dec 5, 2024
7cb84c3
check if setup-python is causing interference
leofang Dec 5, 2024
d97fbdd
fix typo
leofang Dec 5, 2024
59e4e0a
apply a WAR on Linux
leofang Dec 5, 2024
2ab0877
fix unbound var
leofang Dec 5, 2024
cac9de8
detect Python path after it's installed (by CIBW)
leofang Dec 5, 2024
a3ef630
try CIBW_BEFORE_ALL_LINUX
leofang Dec 5, 2024
26af84d
try to restore the pre-py-span setup...
leofang Dec 5, 2024
cdbdfb5
reduce build matrix to experiment with cuda.bindings builds
leofang Dec 6, 2024
8a61031
fix parenthesis
leofang Dec 6, 2024
35b8826
use abs path
leofang Dec 6, 2024
8e42dc4
defer CUDA_PATH setting
leofang Dec 6, 2024
1588e57
use CIBW_ENVIRONMENT to pass env var
leofang Dec 6, 2024
e13854d
fetch cuda-profiler-api headers
leofang Dec 6, 2024
4f73509
only rely on redist
leofang Dec 6, 2024
128ab12
allow wheel repair to fix the triplet tags
leofang Dec 6, 2024
6087a54
restore full build matrix!
leofang Dec 6, 2024
b05e95d
fix wget on Windows; pass PARALLEL_LEVEL to CIBW
leofang Dec 6, 2024
0c91ed8
switch from wget to curl
leofang Dec 6, 2024
33f35c3
windows needs unzip not tar
leofang Dec 6, 2024
4b3341a
mv -> rsync
leofang Dec 6, 2024
3503dae
git bash has no wget or rsync...
leofang Dec 6, 2024
dc12840
ensure win-style path on win
leofang Dec 6, 2024
c55bdc5
convert abs path
leofang Dec 6, 2024
bdb3599
debug
leofang Dec 6, 2024
c8fd323
another level down
leofang Dec 6, 2024
0d554f0
check if it is a race condition on win
leofang Dec 6, 2024
19445d5
clean up unused (but still relevant) code
leofang Dec 6, 2024
15626a8
clean up unused (but still relevant) code - cont'd
leofang Dec 6, 2024
07b8d1d
consolidate with PYTHON_VERSION_FORMATTED
leofang Dec 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
windows needs unzip not tar
leofang committed Dec 6, 2024
commit 33f35c336cb1720eb4cbeb27fe4676cb50456fdd
22 changes: 15 additions & 7 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
@@ -99,21 +99,29 @@ runs:
# The binary archives (redist) are guaranteed to be updated as part of the release posting.
CTK_BASE_URL="https://developer.download.nvidia.com/compute/cuda/redist/"
CTK_JSON_URL="$CTK_BASE_URL/redistrib_${{ inputs.cuda-version }}.json"
if [[ "${{ inputs.host-platform }}" == "linux-x64" ]]; then
CTK_SUBDIR="linux-x86_64"
elif [[ "${{ inputs.host-platform }}" == "linux-aarch64" ]]; then
CTK_SUBDIR="linux-sbsa"
if [[ "${{ inputs.host-platform }}" == linux* ]]; then
if [[ "${{ inputs.host-platform }}" == "linux-x64" ]]; then
CTK_SUBDIR="linux-x86_64"
elif [[ "${{ inputs.host-platform }}" == "linux-aarch64" ]]; then
CTK_SUBDIR="linux-sbsa"
fi
function extract() {
tar -xvf $1 -C $CUDA_PATH --strip-components=1
}
elif [[ "${{ inputs.host-platform }}" == "win-x64" ]]; then
CTK_SUBDIR="windows-x86_64"
function extract() {
_TEMP_DIR_=$(mktemp -d)
unzip $1 -d $_TEMP_DIR_
mv $_TEMP_DIR_/*/* $CUDA_PATH
rmdir $_TEMP_DIR_/* $_TEMP_DIR_
}
fi
function populate_cuda_path() {
# take the component name as a argument
function download() {
curl -kLSs $1 -o $2
}
function extract() {
tar -xvf $1 -C $CUDA_PATH --strip-components=1
}
CTK_COMPONENT=$1
CTK_COMPONENT_REL_PATH="$(curl -s $CTK_JSON_URL |
python -c "import sys, json; print(json.load(sys.stdin)['${CTK_COMPONENT}']['${CTK_SUBDIR}']['relative_path'])")"