Pipeline-parallel support for Knowledge Distillation (NeMo 2) #11766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def forward(self, batch: Dict[str, Tensor], forward_out: Tensor) -> Tuple[Tensor, Dict[str, Tensor]]: | ||
| if isinstance(forward_out, tuple): | ||
| # neva returns (logits, loss_mask) | ||
| forward_out, batch["loss_mask"] = forward_out |
Check notice
Code scanning / CodeQL
Unused local variable Note
AAnoosheh
force-pushed
the
aanoosheh/pp-distillation-nemo2
branch
from
0ce6e7d to
b748ae8
Compare
| if self._kd_teacher_in_pp: | ||
| with self.unwrapped_model.only_teacher_forward(): | ||
| with self.unwrapped_model.swap_teacher_config(self.module): | ||
| teacher_step() |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
| from nemo import lightning as nl | ||
| from nemo.collections import llm | ||
| from nemo.collections.llm.gpt.model.base import get_batch_on_this_context_parallel_rank | ||
| from nemo.collections.llm.inference.base import _setup_trainer_and_restore_model |
Check notice
Code scanning / CodeQL
Unused import Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enable Pipeline-Parallelism in conjunction with student-teacher distillation in NeMo 2
Collection: [LLM]
Changelog
MegatronParallelforward pass to run teacher in addition to studentUsage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information