Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Triton patch for Pallas builds #505

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jan 30, 2024

It seems that the HEAD~2 trick is no longer needed, as Python bindings are still there in the tag referred to by XLA.
The is_hip() patch no longer applies because of https://github.com/openai/triton/pull/2887/files#diff-3d1f29795218f61553ab953426c15fa1e4162b224405b85529022293054da57aL13-L16.
Pallas is not currently working, so this may need to be re-added in some other form.

@olupton olupton force-pushed the olupton/remove-pallas-triton-is_hip-patch branch from 8e423c2 to 506bf68 Compare January 30, 2024 15:37
@yhtang
Copy link
Collaborator

yhtang commented Jan 30, 2024

Could you please provide an overview of the Pallas status?

Pallas is not currently working, so this may need to be re-added in some other form.

Could you please provide a little more detail on what is working and what is not?

@olupton
Copy link
Collaborator Author

olupton commented Jan 31, 2024

Pallas is not currently working, so this may need to be re-added in some other form.

Could you please provide a little more detail on what is working and what is not?

There is work ongoing on the JAX side to change how lowering to Triton is organised.
Currently some relevant parts of the jaxlib wheels are broken, e.g.

from jaxlib.mlir import ir
from jaxlib.triton import dialect as tt_dialect
ctx = ir.Context()
tt_dialect.register_dialect(ctx)

reproduces the error seen in our nightly tests.

Older images, such as https://github.com/NVIDIA/JAX-Toolbox/pkgs/container/jax/168056269?tag=nightly-pallas-2023-12-16, pre-date these ongoing changes to JAX and should work.

This PR is attempting to fix the mechanics of the nightly image build (which is currently failing), and in the first instance get us back to reproducing the error linked above in our nightly builds. We should also fix the badge, as the error is included in summaries but not made obvious from the README.

@olupton olupton force-pushed the olupton/remove-pallas-triton-is_hip-patch branch from 506bf68 to f79bdc1 Compare January 31, 2024 20:13
@olupton olupton requested a review from yhtang January 31, 2024 20:52
@olupton olupton marked this pull request as ready for review January 31, 2024 20:53
@olupton olupton merged commit 683b279 into main Feb 1, 2024
109 of 112 checks passed
@olupton olupton deleted the olupton/remove-pallas-triton-is_hip-patch branch February 1, 2024 07:00
ashors1 pushed a commit that referenced this pull request Feb 3, 2024
It seems that the `HEAD~2` trick is no longer needed.
The `is_hip()` patch no longer applies because of triton-lang/triton#2887.
Pallas is not currently working, so this may need to be re-added in some
other form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants