Skip to content

Commit 2fe3403

Browse files
oluptonashors1
authored andcommitted
Remove Triton patch for Pallas builds (#505)
It seems that the `HEAD~2` trick is no longer needed. The `is_hip()` patch no longer applies because of triton-lang/triton#2887. Pallas is not currently working, so this may need to be re-added in some other form.
1 parent 3ddc59b commit 2fe3403

File tree

4 files changed

+24
-51
lines changed

4 files changed

+24
-51
lines changed

.github/container/Dockerfile.pallas

+2-3
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,10 @@ ARG SRC_PATH_TRITON
1313
# in the manifest file is consistent with the commit of xla
1414
RUN get-source.sh -l openxla-triton -m ${MANIFEST_FILE}
1515

16-
ADD triton-is_hip.patch /opt
17-
RUN cd "${SRC_PATH_TRITON}" && patch -p1 < /opt/triton-is_hip.patch && git diff
18-
1916
RUN <<"EOF" bash -ex
2017
mkdir -p "${SRC_PATH_TRITON}/dist"
18+
sed -i 's|backends = _copy_backends(\["nvidia", "amd"\])|backends = _copy_backends(["nvidia"])|g' "${SRC_PATH_TRITON}/python/setup.py"
19+
sed -i '1s|^|include_directories(${CMAKE_SOURCE_DIR}/third_party/nvidia/backend/include)\n|' "${SRC_PATH_TRITON}/lib/Conversion/TritonGPUToLLVM/CMakeLists.txt"
2120
pip wheel --wheel-dir="${SRC_PATH_TRITON}/dist" "${SRC_PATH_TRITON}/python"
2221
EOF
2322

.github/container/bump-openxla-triton.sh

+1-9
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,4 @@ git clone --branch "${xla_tracking_ref}" --single-branch "${xla_url}" "${xla_rep
6262
# patches in this .bzl file, but skip that for now.
6363
openxla_triton_tag=$(sed -n -e 's#\s\+TRITON_COMMIT = "\(cl[0-9]\+\)"#\1#p' "${xla_repo}/third_party/triton/workspace.bzl")
6464
rm -rf "${xla_repo}"
65-
openxla_triton_url=$(yq e ".openxla-triton.url" $MANIFEST)
66-
openxla_triton_repo=$(mktemp -d /tmp/openxla-triton.XXXXXX)
67-
git clone --branch "${openxla_triton_tag}" --single-branch --depth 3 "${openxla_triton_url}" "${openxla_triton_repo}"
68-
# Undo two changes that Google always apply to the openxla/triton@llvm-head
69-
# branch that these tags are based off, because they remove the Python
70-
# bindings that we need.
71-
openxla_triton_commit=$(cd "${openxla_triton_repo}" && git rev-parse --verify HEAD~2)
72-
rm -rf "${openxla_triton_repo}"
73-
yq e ".openxla-triton.latest_verified_commit = \"${openxla_triton_commit}\"" -i $MANIFEST
65+
yq e ".openxla-triton.latest_verified_commit = \"${openxla_triton_tag}\"" -i $MANIFEST

.github/container/manifest.yaml

+21-21
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,31 @@
22
jax:
33
url: https://github.com/google/jax.git
44
tracking_ref: main
5-
latest_verified_commit: 46f796b38d3a030c4a2e2cde3b1aeb610bba8826
5+
latest_verified_commit: 9e76e380cc47f28c5f08be7497293f51e1c1d167
66
mode: git-clone
77
xla:
88
url: https://github.com/openxla/xla.git
99
tracking_ref: main
10-
latest_verified_commit: 59d9399856954967b8019a8311e4ed521859621d
10+
latest_verified_commit: 0dc5563a97d6fa4584b85cb29b4bfcf289604f0b
1111
mode: git-clone
1212
flax:
1313
url: https://github.com/google/flax.git
1414
mirror_url: https://github.com/nvjax-svc-0/flax.git
1515
tracking_ref: main
16-
latest_verified_commit: 97e9c704d978fdd2296976dafe1e324b6b8fa774
16+
latest_verified_commit: 12b3db0cffd521c707ca959818b7ab1a274a98fd
1717
mode: git-clone
1818
patches:
1919
pull/3340/head: file://patches/flax/PR-3340.patch # Add Sharding Annotations to Flax Modules
2020
transformer-engine:
2121
url: https://github.com/NVIDIA/TransformerEngine.git
2222
tracking_ref: main
23-
latest_verified_commit: 178f13656ad9abc5e1c6758b6e126bdd367960b7
23+
latest_verified_commit: 44574def7f34fb61bebd458b74c47fe33acec57d
2424
mode: git-clone
2525
t5x:
2626
url: https://github.com/google-research/t5x.git
2727
mirror_url: https://github.com/nvjax-svc-0/t5x.git
2828
tracking_ref: main
29-
latest_verified_commit: ed43961aebb179870b829e59cdd39a707f796656
29+
latest_verified_commit: 4ff4291b208cfbc199409e25990e2c01183eacb1
3030
mode: git-clone
3131
patches:
3232
mirror/patch/partial-checkpoint-restore: file://patches/t5x/mirror-patch-partial-checkpoint-restore.patch # pull/1392/head # https://github.com/google-research/t5x/pull/1392: Add support for partial checkpoint restore
@@ -36,15 +36,15 @@ paxml:
3636
url: https://github.com/google/paxml.git
3737
mirror_url: https://github.com/nvjax-svc-0/paxml.git
3838
tracking_ref: main
39-
latest_verified_commit: 19db52eed85ae0d2365339b83a97cd0b873bbf73
39+
latest_verified_commit: d7b78d39d04c03ff45c5fe0f74f6d281ab36bb69
4040
mode: git-clone
4141
patches:
4242
pull/46/head: file://patches/paxml/PR-46.patch # adds Transformer Engine support
4343
praxis:
4444
url: https://github.com/google/praxis.git
4545
mirror_url: https://github.com/nvjax-svc-0/praxis.git
4646
tracking_ref: main
47-
latest_verified_commit: 43e9e2ce1179efdc064277b04e16eedcd47e9558
47+
latest_verified_commit: 8a25c60f003ab7cdd5e305b88bd677b2d2c0ee00
4848
mode: git-clone
4949
patches:
5050
pull/27/head: file://patches/praxis/PR-27.patch # This PR allows XLA:GPU to detect the MHA pattern more easily to call fused kernels from cublas.
@@ -53,7 +53,7 @@ lingvo:
5353
# Used only in ARM pax builds
5454
url: https://github.com/tensorflow/lingvo.git
5555
tracking_ref: master
56-
latest_verified_commit: c33b460ae9208323b664c5bd565899dcd9c2e42c
56+
latest_verified_commit: c3fc4d7a50f2e2c2e189a2ef29b7b65da1597420
5757
mode: git-clone
5858
tensorflow-text:
5959
# Used only in ARM pax and t5x builds
@@ -68,13 +68,13 @@ pydantic:
6868
fiddle:
6969
url: https://github.com/google/fiddle.git
7070
tracking_ref: main
71-
latest_verified_commit: dbe479bf6ccb2b6edaa6fe0843d5d0d9182f8d57
71+
latest_verified_commit: 7a12009bf9d07652759e8554fa93135b2d63fd41
7272
mode: pip-vcs
7373
# Used by t5x
7474
airio:
7575
url: https://github.com/google/airio.git
7676
tracking_ref: main
77-
latest_verified_commit: 98252982483053a61e71d819461b459d7232662e
77+
latest_verified_commit: 6a98fbe27a9b23954748bed7181b913ab8d20753
7878
mode: pip-vcs
7979
clu:
8080
url: https://github.com/google/CommonLoopUtils.git
@@ -89,12 +89,12 @@ dllogger:
8989
jestimator:
9090
url: https://github.com/google-research/jestimator.git
9191
tracking_ref: main
92-
latest_verified_commit: fa143d93e337ca8ab77c4510baf21ae52af24ab2
92+
latest_verified_commit: 6a57d35539f5193a9756a7cb846654e9b221b2e7
9393
mode: pip-vcs
9494
optax:
9595
url: https://github.com/google-deepmind/optax.git
9696
tracking_ref: main
97-
latest_verified_commit: 5e6bca05708c26a8f966490c53bb1bf8036c3c43
97+
latest_verified_commit: dff502082bfd902db6dd079f3bf754887c87f3ca
9898
mode: pip-vcs
9999
seqio:
100100
url: https://github.com/google/seqio.git
@@ -105,38 +105,38 @@ seqio:
105105
openxla-triton:
106106
url: https://github.com/openxla/triton.git
107107
tracking_ref: llvm-head
108-
latest_verified_commit: 09ddf3b32b7ac777c5f57c3c8e9ba18d8adf7ccb
108+
latest_verified_commit: cl601105910
109109
mode: git-clone
110110
jax-triton:
111111
url: https://github.com/jax-ml/jax-triton.git
112112
tracking_ref: main
113-
latest_verified_commit: 4af0ecb709f46633de59342a16e15454f5fcdcfa
113+
latest_verified_commit: 28ad4766271a181587e6e17e17de7f729c1a03b5
114114
mode: git-clone
115115
maxtext:
116116
url: https://github.com/google/maxtext.git
117117
tracking_ref: main
118-
latest_verified_commit: ec9cdce1928fb36f93e498c8f74f8f130bad3dc2
118+
latest_verified_commit: ddcd1c44d6b4295f234d86e572b6a8b68d71abf6
119119
mode: git-clone
120120
levanter:
121121
url: https://github.com/stanford-crfm/levanter.git
122-
tracking_ref: main
123-
latest_verified_commit: 8250b776c28f2d929c4c095dc571b12f128ec11d
122+
tracking_ref: main
123+
latest_verified_commit: 0e1f2dcb39a33d251992438360357b65c53de941
124124
mode: git-clone
125125
haliax:
126126
url: https://github.com/stanford-crfm/haliax.git
127127
tracking_ref: main
128-
latest_verified_commit: 0f29c95eea05ed9e2d9d01c7ae48f4231cf1a57d
128+
latest_verified_commit: ae5f4ce74a429a9ae45e350099f2ecc0cd95004c
129129
mode: git-clone
130130
mujoco:
131131
url: https://github.com/google-deepmind/mujoco.git
132132
tracking_ref: main
133-
latest_verified_commit: 4f53d9a0d7bde4b9a69994d79449dfd57a04c305
134-
mode: git-clone
133+
latest_verified_commit: fae1f3e56d5a1df93da510462a17432b7b91b0a0
134+
mode: git-clone
135135
grain:
136136
# Used only in ARM t5x builds
137137
url: https://github.com/google/grain.git
138138
tracking_ref: main
139-
latest_verified_commit: b02754da440d7271c3ea687f2d3fe20c672ea91b
139+
latest_verified_commit: fa79b9dea81ffb00555a6c2ae2898be4bdd5e564
140140
mode: git-clone
141141
mujoco-mpc:
142142
url: https://github.com/google-deepmind/mujoco_mpc.git

.github/container/triton-is_hip.patch

-18
This file was deleted.

0 commit comments

Comments
 (0)