Skip to content

Commit cc4f973

Browse files
authored
Always bump manifest and save as a new file in CI (#550)
This is to avoid future incidents like https://github.com/NVIDIA/JAX-Toolbox/actions/runs/7913764480, where an error introduced via [an earlier PR](https://github.com/NVIDIA/JAX-Toolbox/pull/542/files#diff-fe97711a3e6691d7687dcb162852ad8d926930e75cb7bcba71b5eaa3112056efR153) was not catched by presubmit CI because the job that uses it only runs during the nightlies.
1 parent ed39fc3 commit cc4f973

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

.github/workflows/_build_base.yaml

+8-2
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,18 @@ jobs:
6363
- name: Check out the repository under ${GITHUB_WORKSPACE}
6464
uses: actions/checkout@v4
6565

66-
- name: Update manifest and patches in-place - show diff
66+
- name: Test if manifest bump is functional, and save result to a new file
67+
working-directory: .github/container
68+
shell: bash -x -e {0}
69+
run: |
70+
bash bump.sh --input-manifest manifest.yaml --output-manifest manifest.yaml.new
71+
72+
- name: Replace current manifest with the new one and show diff
6773
if: inputs.BUMP_MANIFEST
6874
working-directory: .github/container
6975
shell: bash -x -e {0}
7076
run: |
71-
bash bump.sh --input-manifest manifest.yaml
77+
mv manifest.yaml.new manifest.yaml
7278
git diff
7379
7480
- name: Upload bumped manifest to be used in build-base

0 commit comments

Comments
 (0)