Fix badge publication in CI (#549)

There is a typo that causes deletion of old badges to fail. This was not
captured in the presubmit because the badge publication job did not run.
I've changed it to run regardless whether the workflow is presubmit or
nightly, but let the publishing destination be a mock one if the
workflow is run as presubmit.

Author: yhtang

Diff for: .github/workflows/_finalize.yaml

@@ -172,7 +172,6 @@ jobs:
 
   publish-badge:
     needs: [upload-badge]
-    if: inputs.PUBLISH_BADGE == true
     runs-on: ubuntu-22.04
     env:
       # Name/bash regex for shields.io endpoint JSON files
@@ -184,14 +183,9 @@ jobs:
           github-token: ${{ secrets.NVJAX_GIST_TOKEN }}
           script: |
             const srcId = "${{ needs.upload-badge.outputs.GIST_ID }}";
-            const dstId = "${{ vars.BADGE_ENDPOINT_GIST_ID }}";
+            const dstId = "${{ inputs.PUBLISH_BADGE && vars.BADGE_ENDPOINT_GIST_ID || vars.MOCK_BADGE_ENDPOINT_GIST_ID }}";
             const { PUBLISH_BADGE_FILES } = process.env;
 
-            // Fetch files from source gist
-            const { data: srcData } = await github.rest.gists.get({
-              gist_id: srcId
-            });
-
             // Fetch existing files from destination gist
             const { data: dstData } = await github.rest.gists.get({
               gist_id: dstId
@@ -200,11 +194,14 @@ jobs:
             // Mark existing files in destination gist for deletion
             let filesToUpdate = {};
             for (const filename of Object.keys(dstData.files)) {
-              filesToUpdate[filename] = {
-                content: null
-              };
+              filesToUpdate[filename] = null;
             }
 
+            // Fetch files from source gist
+            const { data: srcData } = await github.rest.gists.get({
+              gist_id: srcId
+            });
+
             // Add or update files based on the pattern
             const pattern = new RegExp(`${PUBLISH_BADGE_FILES}`);
             for (const [filename, fileObj] of Object.entries(srcData.files)) {