Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output field updates: Well depth, non-vertical sections, transmission, annualized capex [3.7.0] #329

Merged
merged 14 commits into from
Jan 21, 2025

Conversation

softwareengineerprogrammer
Copy link
Collaborator

@softwareengineerprogrammer softwareengineerprogrammer commented Jan 20, 2025

  1. Rename Well depth (or total length, if not vertical) to Well depth per Laterals/horizontals/non-vertical sections not reflected in "Well depth (or total length, if not vertical)" #321. This update is the motivation for the minor version bump from 3.6 to 3.7, since renaming this field is technically a backwards-incompatible change. I considered avoiding introducing backwards-incompatibility, but ultimately landed on the minor version bump for the following reasons:
    1. The previous field name - Well depth (or total length, if not vertical) - was inaccurate and actively misleading. The actual value was always just the well depth and never total length, even if not vertical.
    2. The field was/is also redundant with the Reservoir Depth input. Thus it's less likely that anyone programmatically consuming the client results would be consuming this field specifically, lessening impact of the backwards-incompatible change.
  2. Fix non-vertical drilling costs field parsing
  3. Add missing capex fields to client result: Transmission pipeline cost, Annualized capital costs

@softwareengineerprogrammer softwareengineerprogrammer changed the title Output field updates: Well depth, non-vertical sections, annualized capex [3.7.0] Output field updates: Well depth, non-vertical sections, transmission, annualized capex [3.7.0] Jan 20, 2025
@softwareengineerprogrammer softwareengineerprogrammer linked an issue Jan 21, 2025 that may be closed by this pull request
@softwareengineerprogrammer
Copy link
Collaborator Author

softwareengineerprogrammer commented Jan 21, 2025

TODO: in documentation, add note on Output parameter indicating "Well depth" = "Vertical depth"/TVD

Copy link
Collaborator

@jeffbourdier jeffbourdier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@softwareengineerprogrammer softwareengineerprogrammer merged commit 81caf47 into NREL:main Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-vertical section result field typos
2 participants