-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output field updates: Well depth, non-vertical sections, transmission, annualized capex [3.7.0] #329
Merged
softwareengineerprogrammer
merged 14 commits into
NREL:main
from
softwareengineerprogrammer:main
Jan 21, 2025
Merged
Output field updates: Well depth, non-vertical sections, transmission, annualized capex [3.7.0] #329
softwareengineerprogrammer
merged 14 commits into
NREL:main
from
softwareengineerprogrammer:main
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depth' - claim of total length if not vertical is not accurate. NREL#321
"Well depth" instead of "Well depth (or total length, if not vertical)"
TODO: in documentation, add note on Output parameter indicating "Well depth" = "Vertical depth"/TVD |
jeffbourdier
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well depth (or total length, if not vertical)
toWell depth
per Laterals/horizontals/non-vertical sections not reflected in "Well depth (or total length, if not vertical)" #321. This update is the motivation for the minor version bump from 3.6 to 3.7, since renaming this field is technically a backwards-incompatible change. I considered avoiding introducing backwards-incompatibility, but ultimately landed on the minor version bump for the following reasons:Well depth (or total length, if not vertical)
- was inaccurate and actively misleading. The actual value was always just the well depth and never total length, even if not vertical.Reservoir Depth
input. Thus it's less likely that anyone programmatically consuming the client results would be consuming this field specifically, lessening impact of the backwards-incompatible change.Transmission pipeline cost
,Annualized capital costs