Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sampling documentation #278

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amylebar
Copy link
Contributor

@amylebar amylebar commented Feb 6, 2025

Pull request overview

  • Replace sampling methodology section with details about the new sampling method
  • Minor updates to the natural gas, and propane and fuel oil utility bill sections to make them clearer

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • ComStock documentation updated
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@amylebar amylebar requested a review from mpraprost February 6, 2025 19:37
@amylebar amylebar requested review from mpraprost and removed request for mpraprost February 6, 2025 19:37
@amylebar amylebar removed their assignment Feb 6, 2025
@amylebar amylebar added documentation PR improves or adds documentation Pull Request - Ready for CI labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation PR improves or adds documentation Pull Request - Ready for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants