-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dockerfile to custom ghedesigner version #266
Open
mpraprost
wants to merge
81
commits into
main
Choose a base branch
from
ghedesigner_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at-measures For test - fix bugs for df lighting and tstat measures
bring measure changes from fan_updates_6 branch
change to stds method
This commit should not be merged back to main after the SDR is complete.
Updates column definitions to match: 1. sampling-related changes (rentable_area -> building_area, floor_area_category) 2. column name changes in that have occurred in the reporting measure: (furnace -> gas_coil, gas_coil -> primary/secondary) 3. seasonal daily average emissions 4. disable reporting of columns unused by any ComStock systems.
… & savings and emission intensity & savings (#257) * initial implementation for test * add more * updates fix bugs in added functions, update naming conversion and unit conversion, update column_definition * update column definitions and downselect a few entries * initial implementation for test * add more * updates fix bugs in added functions, update naming conversion and unit conversion, update column_definition * update column definitions and downselect a few entries * not include these var by default * clean up unnecessary condition
Use future pandas behavior, which we handled by casting column type after .replace() calls. Suppresses warning messages when creating CBECS objects.
…error catching remediation and style cleanups.
… wenyi/euss_r3
Move the functionality to export the metadata in OEDI format from telescope into comstockpostproc to accommodate the improved geospatial resolution.
Removes unused or duplicative variables. Should not change calculation functionality.
A few geography columns above the tract level exist in the fkt after creation. Drop all but the tract column from fkt, and join on all the geography columns from the spatial lookup based on the tract after joining onto results for the geography.
Enable loading of apportionment data from parquet file which is written to disk after successful creation during an earlier run. Because apportionment can be slow, this can significantly speed up work on postprocessing.
Consolidated four individual unweighted savings column methods into one
Reduce info messages to make it easier to see warnings and errors
Now that multiple data sources have the same column name it is necessary to downselect to the unique set.
fkt creation is non-deterministic. Cache fkt so it can be reused when a data export is interrupted and needs to be restarted. Hive partition the ComStock wide data to enable much faster filtering down to the upgrade, which was a major bottleneck in exporting data for each geography.
Use the 'detailed' keyword to export all columns present in the raw data, primarily used for internal testing and debugging.
Actually compress gz file, code from @wenyikuang
Collect all geographic aggregates in one frame then split the collected frame into individual geographies. This speeds up the processing significantly for by_state aggregates.
PUMAs should be added to fkt during creation, so this change is temporary.
For aggregates, the full dataframe may be collected without memory issues. For non-aggregates, need to collect a dataframe per geography to avoid memory issues.
If there is no aggregation, collect the entire first-level geography at once and then sub-divide this to separate files later.
Allows an array of variables to be used when aggregating. Helpful when you need multiple geographic variables like state and climate zone included in the output files.
Fixes national-scale partitioning to work when no aggregation is supplied.
Reduce the bottleneck for metadata export by parallelizing writing metadata files
Updates postprocessing for new sampling / increased geographic resolution
…lures in the utility bill measure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author: Marley
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/reporting_measure_tests.txt
,test/workflow_measure_tests.txt
, ortest/upgrade_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File