p2l attribute issue

[mickaelaccensi]

Pull Request Summary

correct the attributes on p2l output variable to apply correct units and scale_factor depending on output field type (integer or real)

Description

correct the attributes on p2l output variable to apply correct units and scale_factor depending on output field type (integer or real)
ww3_tp1.7 would be the only one affected by the changes

Issue(s) addressed

solve issue #1394 and minor issue #1393

Commit Message

correct the attributes on p2l output variable

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? matrix
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) ww3_tp1.7
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? datarmor, intel compiler
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.) only in netcdf output field containing p2l variable
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt): ongoing

[sbanihash]

Thank you @mickaelaccensi for working on this fix and submitting the PR. I will be reviewing this PR soon.

[JessicaMeixner-NOAA]

FYI @kestonsmith-noaa - This might be relevant to work you are doing.

[JessicaMeixner-NOAA]

Thanks @mickaelaccensi

*********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp1.7/./work_PR3_UQ                     (1 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_tp2.7/./work_ST0                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

All are either know b4b or the tp1.7 and ww3_tp2.7/./work_ST0 is because no more fort.10111 file.

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt