-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Positivity fktables at Q2 = 10 #2285
base: master
Are you sure you want to change the base?
Conversation
Please, remove the fonll cards. At the moment when you generate them with pineko they would be created in whatever folder the original card is anyway. Personally I'd prefer if we remove completely the need for this intermediate theory cards... cc @felixhekhorn @giacomomagni |
The whole point is that nFONLL works at observable level so you need an fktable for each nf. We can indeed choose not to store the theory cards anywhere, and this is probably a reasonable thing to do (like arguably we shouldn't store the operatorcards), especially in the nnpdf_data repo, but we can't entirely avoid intermediate theory cards (and ekos, and fktables). |
Indeed. As I already argued in NNPDF/pineko#202 having different theory (and operator) cards disentangles the programs: eko <-> pineko <-> pinefarm If and where to store them (while being generated objects) is a separate issue ... |
nnpdf_data/nnpdf_data/commondata/NNPDF_POS_3P16GEV/kinematics_F2U.yaml
Outdated
Show resolved
Hide resolved
It requires a different grid per nf but a single fktable. Given a theory (meaning, the main theory) the theory cards for all 6 grids are fixed so there's no need (and we should not) keep all these 6 extra theories. edit: clearly all solutions until now have been confusing for everyone who has been dealing with it. |
mmh, almost no: there are 7 theory cards and 7 different grids. There is one eko per nf.
for you as a PDF fitter it may look like this - but as soon as you undo the tiny final step (for getting this 1 FK table) the answer is: no, there are 7 FK tables, which are plainly summed over. And we need these 7 FK tables and they are (more or less) fully reasonable FK tables.
this is doable by not committing them here (so you don't see them) - but locally we need them.
fine, we can/should improve the documentation, but https://pineko.readthedocs.io/en/latest/theory/fonll.html gives more or less clear instructions on how to proceed. We can leave FONLL to pineko (i.e. NNPDF does not need to care), but we need the details there. And we should leave it only to pineko, i.e. we will not implement the theory expansion procedure (1 -> 7) into pinefarm: those two communicate by the already established interface: theory cards. Since @comane just went through this: do you have a suggestion on how to improve https://pineko.readthedocs.io/en/latest/theory/fonll.html ? |
…nto pos_fktables_q2_10
Let's link the two PRs for easier navigation NNPDF/pinecards#183 |
But this is the PDF fitting repository.
They don't need to be committed anywhere if they can be always regenerated
This is already the case.
The theory cards have never been truly compatible between the two however. But fine, no dependency and no code shared between pinefarm and pineko. This doesn't create any dependency, it just tells people how to do things in the way that everybody has been doing up to now. |
I believe we all agree on that - so that should close the discussion
NNPDF/pinefarm#96 - @comane could you please take care? |
nnpdf31_process: POSITIVITY | ||
experiment: NNPDF | ||
arXiv: | ||
url: https://arxiv.org/abs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://arxiv.org/abs/ | |
url: '' |
FK_tables: | ||
- - NNPDF_POS_F2U_Q2_10 | ||
data_uncertainties: [] | ||
ported_from: POSF2U |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ported_from: POSF2U |
FK_tables: | ||
- - NNPDF_POS_F2D_Q2_10 | ||
data_uncertainties: [] | ||
ported_from: POSF2DW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ported_from: POSF2DW |
pinecards: NNPDF/pinecards#183