New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't error with unexpected end of entry for RFC 3597 RDATA of length zero. #475

Open

ximon18 wants to merge 1 commit into main from fix-rfc-3597-unknown-rdata-len-parsing

Member

ximon18 commented Jan 7, 2025 •

edited

Loading

If the RDATA is of zero length, the text representation contains only
the # token and the single zero representing the length.

However, domain is currently unable to parse such input, e.g. the following produces an unexpected end of entry error:

example.org. 240 IN SOA  example.net. hostmaster.example.net. 1234567890 28800 7200 604800 240
b.example.org   IN          TYPE62347       \# 0

This PR alters the parsing of unknown RDATA so that the end of line check to be before the attempt to consume the next token.


          FIX: Don't error with unexpected end of entry for RFC 3597 RDATA of l…

bbdc1ab

…ength zero.

ximon18 requested a review from a team

January 7, 2025 12:04

ximon18 mentioned this pull request

Add signzone command. NLnetLabs/dnst#8

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet