-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new base
module
#474
Open
bal-e
wants to merge
129
commits into
main
Choose a base branch
from
new-base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It implements 'Hash' for the provided integer types.
I have taken care to preserve explicit parse impls for wrapper types like 'SizePrefixed', and a few cases where performance could matter.
Fixes up the existing codebase against new Clippy lints.
Some DNSSEC types use single-byte prefixed data, for which I'd still like to make use of 'SizePrefixed' to avoid boilerplate.
This will be used for zonefile parsing.
'bumpalo' is useful for allocating unsized data types like record data. It is currently used in the 'new-zonefile' branch as a buffer space for records to be parsed into. 'clone_to_bump()' is necessary in order to deep-copy record data into a new bump allocator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
new_base
module as a potential candidate for replacingbase
. While it has a similar structure, it has some distinguishing features:It uses concrete types (usually slices and references) in place of
Octs
generic parameters. The hard-coded types are ergonomic and efficient and simplify the API.It introduces a new parsing architecture which aggressively avoids copying. The architecture is inspired by the
zerocopy
crate, but allows for partial copying when zero-copy is not possible.derive
macros are provided (and heavily used internally) to avoid boilerplate when implementing the parsing traits.It overhauls the message building process so that truncation errors are handled more gracefully and message components (i.e. questions and records) can be built incrementally. This lays the groundwork for a more efficient client/server architecture where messages are built in-place, even across middleware layers.
It introduces
RevName
, a more efficient type for domain names (where labels are stored in reverse order). Operations onRevName
tend to be more efficient (e.g. canonical-order comparisons are significantly better).Here's the current roadmap:
derive
macros for the parsing/building traits.derive
macros for these traits.derive
macros for these traits.net::server
(in a separate PR) on top ofnew-base
.Note: this is a new version of #469 with a less problematic branch name.