Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bit more metadata to cargo file #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pemensik
Copy link

No description provided.

@ximon18
Copy link
Member

ximon18 commented Nov 15, 2024

Hi @pemensik,

Thankyou very much for taking the time to look at dnst and especially for contributing!

FYI this submission overlaps with work being done in PR #22 to create packages for dnst, see the Cargo.toml from that PR.

Once we've finished work on that PR we can see what differences remain compared to your submission. You can of course also let us know if you think we should be doing anything differently in that PR.

Thanks,

Ximon

@pemensik
Copy link
Author

@ximon18 I am attempting to create rpm package using rust2rpm tool. I am not targetting any specific cargo tool. It just complained about license tag missing, so I imported basic stuff into it.

@pemensik
Copy link
Author

I made my change more atomic. Yours is too large for a single PR, IMO :)

@ximon18
Copy link
Member

ximon18 commented Nov 15, 2024

@ximon18 I am attempting to create rpm package using rust2rpm tool. I am not targetting any specific cargo tool. It just complained about license tag missing, so I imported basic stuff into it.

If I have time I will look at whether it is possible to change the license specified in Cargo.toml to work with your rust2rpm tool as well as our Ploutos tool (which in turn uses cargo-generate-rpm).

@ximon18
Copy link
Member

ximon18 commented Nov 15, 2024

I made my change more atomic. Yours is too large for a single PR, IMO :)

I suppose that's a matter of perspective and policy. The changes in my PR are all part of a single task so should be together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants