Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shim behaviours (debounce and space press) for Button component #231

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add shim behaviours (debounce and space press) for Button component #231

merged 2 commits into from
Jun 10, 2024

Conversation

Tomdango
Copy link
Member

This adds the default shim behaviours from nhsuk-frontend for the Button component.

  1. Treat space bar presses on a Button Link (anchor element) component as a click event to mirror the default button functionality.
  2. Add the preventDoubleClick prop to the Button component to allow the prevention of double-clicks.

@edwardhorsford edwardhorsford mentioned this pull request Jun 10, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Tomdango Tomdango mentioned this pull request Jun 10, 2024
Closed
@Tomdango Tomdango merged commit 41d858c into main Jun 10, 2024
2 checks passed
@Tomdango Tomdango deleted the feature/thju1-reimplement-shim-button-behaviour branch June 10, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhorsford edwardhorsford edwardhorsford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomdango @edwardhorsford