Fix tests! Green Travis build!! :D #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `mktemp()` for builddir so the tests aren't writing in the package dir. Change `julia build_app.jl` call to `--verbose` so that we can see in the Travis output why it's failing. Change build_app.jl script invocation from `@test success(cmd)` to `@test contains(readstring(cmd), "Done building")`. This verifies that the script finishes (the same as the first method), but on a failure it actually prints the output, unlike `@test success` which supresses it. -- Disable blink.jl example test because it's not yet working on Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to test/examples.jl to make more robust accross different systems
(including, of course, Travis). This should make it more robust to other
people's machines as well.
Change .travis.yml to actually build and install Blink, so that the Blink test works on Travis as well! :)