Make cd_to_bundle_resources() callable from Julia (again): switch to external ApplicationBuilderAppUtils package
#55
+29
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for cd_to_bundle_resources
NHDaly
force-pushed
the
get_resources_dir
branch
from
c1bf26b to
6bdc844
Compare
NHDaly
changed the title
ApplicationBuilderUtils moduleApplicationBuilderAppUtils package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the applications to decide whether to cd to resources directory or not. For most command-line applications this is actually not a reasonable default behavior.
Also adds a
get_bundle_resources_dir()so that apps that don't change dirs can still access their bundle resources.Moved those utilities into a new package, which I split out into https://github.com/NHDaly/ApplicationBuilderAppUtils.jl. Added that package as a dependency of this one, but users will need to
Pkg.add("https://github.com/NHDaly/ApplicationBuilderAppUtils.jl")if they want to build their project after this PR.