Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the mac and non-mac code bases! #51

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Conversation

NHDaly
Copy link
Owner

@NHDaly NHDaly commented Apr 16, 2019

Now that the behaviors are the same after #48, we can unify the codebases. I just needed to add a few extra if Sys.isapple() / Sys.iswindows() statements, but altogether not bad.

Still need to merge the test files so that the linux/windows builds are more thoroughly tested.

@nodrygo
Copy link

nodrygo commented Apr 16, 2019 via email

- Fix windows include paths via 'raw""' strings
- Add windows/linux version of cd_to_bundle_resources()
@NHDaly NHDaly merged commit 608de15 into master Apr 18, 2019
@NHDaly NHDaly deleted the mac-linux-windows-merge-2 branch April 18, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants