Add initial support for gage-assisted diversions in channel routing #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
previously approved these changes
Jun 20, 2024
rcabell
force-pushed
the
feature/diversions
branch
from
74e5b09
to
165400e
Compare
scrasmussen
reviewed
Jul 27, 2024
CMakeLists.txt
Outdated
| @@ -205,13 +205,13 @@ if (CMAKE_Fortran_COMPILER_ID MATCHES "GNU.*") | |||
| if (CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 9) | |||
| set (CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fallow-argument-mismatch") | |||
| endif() | |||
| set (CMAKE_Fortran_FLAGS_RELEASE "-O2") | |||
| set (CMAKE_Fortran_FLAGS_RELEASE "-O2 -march=native") | |||
There was a problem hiding this comment.
Tested the removal of the -march=native flag and the tests passed. Seems the differences are just caused by that optimization
There was a problem hiding this comment.
Great find! We may want to introduce that back eventually (after some benchmarking), as it theoretically can improve performance considerably on some systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: ENHANCEMENT
KEYWORDS: diversions,DA,channel routing
SOURCE: NCAR
DESCRIPTION OF CHANGES:
Add initial support for channel diversions. This PR only covers the 'gage-assisted diversion' as used on the Mississippi at the Old River Control Structure.
TESTS CONDUCTED:
NOTES:
Diversions must be specified in a
diversions_fileadded to thehydro.namelist. The format of this file will be documented later as part of the NWM v3.1 release.This PR introduces a small amount of C code to find USGS Timeslice files, and as such, introduces a new model dependency on a C compiler and a POSIX-compliant operating system. This should not pose an undue burden on the vast majority of users.