Issue 714 Bugfix #716
Merged
Issue 714 Bugfix #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
force-pushed
the
bugfix-issue-714
branch
from
de61ef9
to
11712ec
Compare
…ore assigning them to a variable
scrasmussen
force-pushed
the
bugfix-issue-714
branch
from
11712ec
to
35f7b78
Compare
rcabell
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bugfix
KEYWORDS: optional argument check
SOURCE: Soren Rasmussen, NCAR
DESCRIPTION OF CHANGES: Need to check if optional arguments are present before assigning them to a variable. Code cleanup of commented out and dead code.
ISSUE: Fixes #714
TESTS CONDUCTED: Build and ran Croton testcase.
Checklist
NEWS.md