Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Scan Position Variable Type from Float to Int for IODA v2 Compliance #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change Scan Position Variable Type from Float to Int for IODA v2 Compliance #58

wants to merge 1 commit into from
+1 −1

Conversation

amstokely
Copy link
Collaborator

Summary:

This PR updates the scan position variable type from float to int to ensure compliance with the IODA v2 format.

Changes:

  • Modified the scan position variable type from float to int.

Motivation:

  • IODA v2 requires scan position to be stored as an integer rather than a floating-point value.

@amstokely amstokely requested review from mgduda and jim-p-w March 11, 2025 20:43
@amstokely amstokely self-assigned this Mar 11, 2025
jim-p-w
jim-p-w reviewed Mar 11, 2025
View reviewed changes
obs2ioda-v2/src/define_mod.f90
@@ -187,7 +187,7 @@ module define_mod
integer(i_kind), dimension(nsen_info) :: type_sen_info = &
(/ &
nf90_float, &
nf90_float, &
nf90_int, &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loks like it breaks this check:

obs2ioda/obs2ioda-v2/src/hsd.f90

Line 678 in c65c57e

if ( trim(name_sen_info(i)) == 'scan_position' ) then

You should check the other references to type_sen_info

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I'll fix this in my next commit.

@amstokely amstokely requested a review from st-ncar March 12, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p-w jim-p-w jim-p-w left review comments

@mgduda mgduda Awaiting requested review from mgduda

@st-ncar st-ncar Awaiting requested review from st-ncar

At least 2 approving reviews are required to merge this pull request.

Assignees

@amstokely amstokely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amstokely @jim-p-w