Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs in c implementation #13

Merged
merged 1 commit into from
Feb 29, 2024
Merged

bugs in c implementation #13

merged 1 commit into from
Feb 29, 2024

Conversation

havogt
Copy link
Collaborator

@havogt havogt commented Feb 29, 2024

  • atanf -> atan since all computation is in double, it is confusing to keep that in single precision
  • indexing error in copying z boundaries
  • no newline in binary file

@cenamiller cenamiller merged commit 33cde0e into main Feb 29, 2024
1 check passed
@cenamiller cenamiller deleted the fix_c_bugs branch February 29, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants