Worked on ISO datetime format #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhagrg
reviewed
Apr 24, 2024
pyQuARC/code/datetime_validator.py
Outdated
Comment on lines
31
to
33
| parts = datetime_string.split('.') | ||
| if len(parts) == 2: | ||
| datetime_string = parts[0] |
There was a problem hiding this comment.
datetime_string = datetime_string.split('.')[0]
No if condition is necessary.
There was a problem hiding this comment.
removed if condition.
|
LGTM. |
xhagrg
approved these changes
May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to solve this issue.
Overview:
In the pyQuarc, while running the collection, it showed the warning message like this:
Changes made:
Modified the code to solve the showing error that they are not provided in ISO format. Now, no warning shows up like the above. Tested on this 'G184443593-LARC' (echo-g) and 'C179031451-LARC' (echo-c)collection to make sure the if the warning shows up.