Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User annotation libraries #110

Merged
merged 5 commits into from
Oct 23, 2024
Merged

User annotation libraries #110

merged 5 commits into from
Oct 23, 2024

Conversation

doublergreer
Copy link
Contributor

@doublergreer doublergreer commented Oct 15, 2024

Closes #100

  • users can now import a private synbiohub collection from their account to annotate sequences against
  • 2 new API endpoints to add/remove said collection from backend FEATURE_LIBRARIES dictionary for annotation
  • checkboxes are used in UI to select/deselect imported collections for annotation
  • 'x' button in UI allows user to have their collection deleted from server memory

Closes #109

  • other synbiohub instances can be logged into in the synbiohub login modal through a new synbiohub url field
  • no other instance shown by default, but previously logged into instances are saved to local storage for ease of use.

Closes #106

  • tooltips on annotations now lead to the component definition uri, leading to the specific component if from SBH.
  • previously only linked to parent collection used by SYNBICT to annotate

@doublergreer doublergreer changed the title Sbh part download User annotation libraries Oct 15, 2024
@doublergreer doublergreer marked this pull request as ready for review October 15, 2024 17:02
Copy link
Contributor

@cl117 cl117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review from last week was the click before loading and path concatenation with URL errors.

Copy link
Contributor

@cl117 cl117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge. All the bugs fixed.

@cl117 cl117 merged commit 7a9f7a8 into main Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants