Force bundler to use ESM, Integrate naming-convention rule, Fix Dependabot Issue

change/@minecraft-math-bb461699-5321-462b-aa66-0cc4d1e29642.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Update @minecraft/math pre-bundled output to be ES modules based",
+  "packageName": "@minecraft/math",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/eslint-plugin-minecraft-linting-044a004a-5e29-41fd-b957-fcf9f4409d20.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Integrate naming convention rule and force bundler to use ESM by adjusting TSConfig",
+  "packageName": "eslint-plugin-minecraft-linting",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

tools/eslint-config-minecraft-scripting/index.mjs

@@ -36,6 +36,7 @@ export default [
             'unicorn/no-null': ['error', { checkStrictEquality: true }],
             '@typescript-eslint/no-empty-function': 'off',
             'no-unused-vars': 'off',
+            '@typescript-eslint/naming-convention': 'error',
             '@typescript-eslint/no-explicit-any': 'error',
             '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
             '@typescript-eslint/no-unused-vars': [

tools/eslint-plugin-minecraft-linting/src/Rules/AvoidUnnecessaryCommand.ts

@@ -31,7 +31,7 @@ function isApiRecommendation(recommendation: ScriptRecommendation): recommendati
 
 // function is
 
-const ScriptRecommendations: Map<string, ApiScriptRecommendation | ClassScriptRecommendation> = new Map([
+const SCRIPT_RECOMMENDATION: Map<string, ApiScriptRecommendation | ClassScriptRecommendation> = new Map([
     [
         '/setblock',
         {
@@ -295,7 +295,7 @@ const ScriptRecommendations: Map<string, ApiScriptRecommendation | ClassScriptRe
     ],
 ]);
 
-const AvoidUnnecessaryCommand = ESLintUtils.RuleCreator(() => 'https://microsoft.com/')<
+const AVOID_UNNECESSARY_COMMAND = ESLintUtils.RuleCreator(() => 'https://microsoft.com/')<
     [],
     'replaceWithScriptMethod' | 'replaceWithScriptFunctionality'
 >({
@@ -324,6 +324,7 @@ const AvoidUnnecessaryCommand = ESLintUtils.RuleCreator(() => 'https://microsoft
     defaultOptions: [],
     create(context, _options): TSESLint.RuleListener {
         return {
+            // eslint-disable-next-line @typescript-eslint/naming-convention
             CallExpression(node) {
                 // Identify if this is a call to runCommand or runCommandAsync, which occurs either
                 // off of the exported module object, or through any cached function reference
@@ -471,7 +472,7 @@ const AvoidUnnecessaryCommand = ESLintUtils.RuleCreator(() => 'https://microsoft
 
                             // Now check if there is a script API that provides the same functionality
                             // by checking our list of recommendations
-                            const recommendation = ScriptRecommendations.get(commandName);
+                            const recommendation = SCRIPT_RECOMMENDATION.get(commandName);
                             if (recommendation) {
                                 // We have a recommendation, so log the appropriate error
                                 if (isClassRecommendation(recommendation)) {
@@ -515,4 +516,4 @@ const AvoidUnnecessaryCommand = ESLintUtils.RuleCreator(() => 'https://microsoft
     },
 });
 
-export default AvoidUnnecessaryCommand;
+export default AVOID_UNNECESSARY_COMMAND;

tools/eslint-plugin-minecraft-linting/src/index.ts

@@ -12,6 +12,7 @@ module.exports = {
         version,
     },
     rules: {
+        // eslint-disable-next-line @typescript-eslint/naming-convention
         'avoid-unnecessary-command': AvoidUnnecessaryCommand,
     },
 };

tools/tsconfig/base.json

@@ -8,15 +8,15 @@
         "forceConsistentCasingInFileNames": true,
         "inlineSources": false,
         "isolatedModules": true,
-        "moduleResolution": "NodeNext",
+        "moduleResolution": "bundler",
         "noUnusedLocals": false,
         "noUnusedParameters": false,
         "preserveWatchOutput": true,
         "skipLibCheck": true,
         "strict": true,
         "sourceMap": true,
         "lib": ["ES2020"],
-        "module": "NodeNext",
+        "module": "ES2020",
         "target": "ES2020"
     },
     "exclude": ["node_modules"]