Denylist feature #396
Denylist feature #396
Conversation
…,and new messages for denylist
|
| @@ -302,6 +303,7 @@ export const getBot = async (bot: Bot<GrammyContext>) => { | |||
|
|
|||
| // Main message composer | |||
| notChannelComposer.use(messagesComposer); | |||
| notChannelComposer.use(denylistComposer); | |||
There was a problem hiding this comment.
It would be best if you used the denylistComposer composer inside the messages composer. Please look at the examples above of the noAntisemitismComposer composer.
| await bot.handleUpdate(update); | ||
|
|
||
| expect(outgoingRequests.length).toEqual(0); | ||
| }); |
There was a problem hiding this comment.
I also would add a case to check it inside a message. So we will be sure that it blocks the message if it's not only the entire block message
|
|
||
| describe('disabled feature', () => { | ||
| beforeAll(() => { | ||
| chatSession.chatSettings.denylist = []; |
There was a problem hiding this comment.
You should not clear the list. It still should include the word. But we need to turn the settings off, and the bot won't delete the message. This is the idea of the test. So please, update it
There was a problem hiding this comment.
I got the idea. You assume the feature is enabled if we have at least one word and turned off if the list is empty. It will work, but we need to give the user more flexibility. Please add an additional checkbox for toggling this feature. It will help temporarily disable the feature without deleting all words.
| const denyWord = denylist.find((word) => text.toLowerCase().includes(word.toLowerCase())); | ||
| if (denyWord) { | ||
| await context.deleteMessage(); | ||
| await logDenylistMessage(context, text); |
There was a problem hiding this comment.
Could you please log the exception word instead of the entire list of words? Logging all the words could break our logs, and we don't really need to. It's more important for us to know the word than the list.
| /** | ||
| * Messages to display when deleting content based on the denylist. | ||
| */ | ||
| export const deleteDenylistMessages = [ |
There was a problem hiding this comment.
I like the list of words! Thanks a lot!
…tg_channels_in_comments
|
No description provided.