Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system-backdrop-controller.md - Add a note that materials with customized properties do not react to theme changes #5293

Open
wants to merge 2 commits into
base: docs
Choose a base branch
from

Conversation

MuyuanMS
Copy link

@MuyuanMS MuyuanMS commented Feb 5, 2025

Add a note on materials with customized controller properties will no longer reacts to Light/Dark theme changes.

Doc change request based on community reported issue for Windows App SDK: microsoft/WindowsAppSDK#3589 and microsoft/WindowsAppSDK#3589, where the developer was confused when, after flipping theme between Dark and Light, materials with non-default controller properties fail to automatically make corresponding changes.

Add note on material with customized controller properties will no longer reacts to Light/Dark theme changes
Copy link
Contributor

@MuyuanMS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit a8e9fa7:

💡 Validation status: suggestions

File Status Preview URL Details
hub/apps/windows-app-sdk/system-backdrop-controller.md 💡Suggestion Details

hub/apps/windows-app-sdk/system-backdrop-controller.md

  • Line 220, Column 132: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /windows/windows-app-sdk/api/winrt/microsoft.ui.composition.systembackdrops.systembackdropconfiguration.theme?view=windows-app-sdk-1.6#microsoft-ui-composition-systembackdrops-systembackdropconfiguration-theme

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 0eac54f:

✅ Validation status: passed

File Status Preview URL Details
hub/apps/windows-app-sdk/system-backdrop-controller.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants