-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing pages for the deprecated marketplace listings #125645
base: main
Are you sure you want to change the base?
Conversation
…vm.md This program is now deprecated and the artifacts mentioned in the article are being removed from the marketplace. Deleting the file to remove the article as well.
@sdubeymsft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 52de259:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/azure-government/documentation-government-impact-level-5.md | Details | ||
articles/azure-government/documentation-government-stig-linux-vm.md | ✅Succeeded | n/a (file deleted or renamed) | |
articles/azure-government/documentation-government-stig-windows-vm.md | ✅Succeeded | n/a (file deleted or renamed) | |
articles/azure-government/index.yml | ✅Succeeded | ||
articles/azure-government/TOC.yml | ✅Succeeded |
articles/azure-government/documentation-government-impact-level-5.md
- Line 422, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: './documentation-government-stig-linux-vm.md'.
- Line 423, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: './documentation-government-stig-windows-vm.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@sdubeymsft Did you intend to make these deletions in the private repo? Deleted files should also get redirects. Leaving this open in case @EliotSeattle wants to chime in. Can you review the proposed changes? You may want to pull these changes into the private repo and make sure to add redirects for the deleted articles. #label:"aq-pr-triaged" |
… to deleted pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to provide a redirect URL for people who try to get to these URLs (by bookmark, say). Do you have existing page(s) that would be appropriate to move people to? Either you or I can take care of those additions to the \azure-docs-pr-eliotgra.openpublishing.redirection.government.json file. I think it's just these two, right?
articles/azure-government/documentation-government-stig-linux-vm.md
articles/azure-government/documentation-government-stig-windows-vm.md
@v-dirichards I've never pulled from azure-docs to the azure-docs-pr repo. Sounds like a lot might go wrong if I tried. ;-) Is that something that you could do? I agree that, unless there's an objection on unusual grounds from @sdubeymsft that we'd want to delete these files and pull in the ToC changes in the private repo as well.
Thanks,
Eliot
Learn Build status updates of commit dc0da0a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
@EliotSeattle Thank you for your help. Yes, we can use "https://learn.microsoft.com/en-us/azure/automation/automation-dsc-configuration-based-on-stig" as redirect for both of the deleted pages? I didn't find the file you mentioned at that location in azure-docs repo? Yes, these are the only two files. Yes, changes apply to private repo as well. Let me know if you would like me to create a separate PR in private repo. Thank you. |
The marketplace listings referenced on the docs are deprecated and removed. Removing the relevant documentation.