-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix umask default for DrvFs automount #2004
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit 0a58727: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 259673d: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Resolves MicrosoftDocs#1628 by making docs consistent with real behavior tested in WSL2. (Also resolves MicrosoftDocs#1767 by making the table consistent with the following paragraph, but note from testing, it was the paragraph that didn't match the real behavior, not the table.)
Learn Build status updates of commit 78aa28a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 78aa28a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Hi team, I updated the PR to resolve merge conflicts. I'd also like to clarify what this is about. From testing, WSL has a default umask of 000, not 022, as mentioned in #1628:
This also fixes a related inconsistency pointed out in #1767 (but by changing the following paragraph, not the table):
I added info about testing done to the original post. Thanks! |
Fixes #1628 and fixes #1767 so that the docs are consistent with the real behavior of WSL2. From testing, WSL has a default umask of 000, not 022.
Testing done
touch /mnt/c/temp/testfile
.[automount]
section does not contain the key-value pairoptions = ...
and save the file. This ensures the default umask is applied.wsl.exe --shutdown
.Note that all the permission bits are set, meaning the default umask is
000
: anyone can read, write, or execute files.