Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1775 interface class extensions added #1776

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johnsonjo4531
Copy link

Let me know if I can do anything to help get this merged I would appreciate any feedback too.

…alLytek#1775)

These tests will fail without the next upcoming commit which adds extensions into the InterfaceType.
…k#1775)

The tests in extensions.ts from commit 4482b68 will fail without this commit.
@MichalLytek
Copy link
Owner

Can you make sure it works when object type extends interface type and when one interface type extends another interface type?

@MichalLytek MichalLytek added Enhancement 🆕 New feature or request Community 👨‍👧 Something initiated by a community labels Mar 4, 2025
… extends interface type related to (MichalLytek#1775)

Made sure the tests and code works when object type extends interface type and when one interface type extends another interface type.
@johnsonjo4531
Copy link
Author

@MichalLytek just made another commit. Are the new test cases what you expected? 😄👍

@johnsonjo4531
Copy link
Author

Fixes #1775

@johnsonjo4531
Copy link
Author

Can you make sure it works when object type extends interface type and when one interface type extends another interface type?

By the way I got this request done @MichalLytek in my last commit. Let me know if there is anything I can do more to get this merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants