Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move the SnapExecutionService render up in the stack #13998

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 13, 2025

Description

This fixes the issue on main where there are errors accessing snap execution webview. The fix was to move the SnapExecutionWebView up in the stack since it needs to render before being accessed by the Engine

Thread - https://consensys.slack.com/archives/C07M5L4U51U/p1741817154708019

Related issues

Fixes: https://consensys.slack.com/archives/C07M5L4U51U/p1741817154708019

Manual testing steps

  1. Run flask build ensuring that Solana accounts are enabled
  2. Try to add a Solana account
  3. Solana account creation should work

Screenshots/Recordings

Before

After

Reach out to @Cal-L for vid

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners March 13, 2025 05:32
@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Mar 13, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 13, 2025
@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 13, 2025
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team and removed team-mobile-platform Mobile Platform team labels Mar 13, 2025
Copy link
Contributor

github-actions bot commented Mar 13, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 40e2e1d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a9866e4f-9403-4898-b15b-d11699bed9b2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Cal-L Cal-L enabled auto-merge March 13, 2025 05:38
owencraston
owencraston previously approved these changes Mar 13, 2025
@FrederikBolding FrederikBolding added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 13, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3b58739
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0ba5ebc-6ee7-45f8-b82b-1a06527a7084

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform Mobile Platform team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

4 participants