-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move the SnapExecutionService render up in the stack #13998
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
|
Description
This fixes the issue on main where there are errors accessing snap execution webview. The fix was to move the
SnapExecutionWebView
up in the stack since it needs to render before being accessed by the EngineThread - https://consensys.slack.com/archives/C07M5L4U51U/p1741817154708019
Related issues
Fixes: https://consensys.slack.com/archives/C07M5L4U51U/p1741817154708019
Manual testing steps
Screenshots/Recordings
Before
After
Reach out to @Cal-L for vid
Pre-merge author checklist
Pre-merge reviewer checklist