Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BSC to supported chains #13964

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

httpJunkie
Copy link
Contributor

Description

What is the reason for the change?

Smart Transactions are not currently supported on BNB Smart Chain. As part of our effort to expand Smart Transactions functionality to more networks, BSC needs to be added to the list of supported chains.

What is the improvement/solution?

This PR adds BSC to the list of supported chains for Smart Transactions in the mobile app by:

  • Adding NETWORKS_CHAIN_ID.BSC to ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_DEVELOPMENT for testing in development environments
  • Temporarily keeping BSC commented out in production with a TODO comment for when backend support is ready
  • Updating tests to reflect these changes

These changes allow the app to recognize Base as a valid network for Smart Transactions in development environments, while ensuring we maintain a safe rollout approach for production.

Open in GitHub Codespaces

Related issues

Fixes:
TXL-704

Manual testing steps

Since Base isn't fully supported in production yet, this PR implements a phased approach:

  1. Enable BSC for Smart Transactions in development environments
  2. Keep it commented out in production until backend support is verified
  3. Update UI text to be network-agnostic

Manual testing included:

  • Verified existing Smart Transactions still work on Ethereum Mainnet
  • Checked network switching between supported networks
  • Confirmed Smart Transactions settings UI correctly displays the updated description
  • Verified Smart Transactions can be toggled on/off in settings

Screenshots/Recordings

Before

Settings description specifically mentioned Ethereum Mainnet only

After

Settings description is now more generic to accommodate multiple supported networks

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

- BSC is commented in Production array until ready.
@httpJunkie httpJunkie self-assigned this Mar 11, 2025
@httpJunkie httpJunkie requested a review from a team as a code owner March 11, 2025 19:31
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@httpJunkie httpJunkie added the team-transactions Transactions team label Mar 11, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 11, 2025
@httpJunkie httpJunkie added release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 49c1e58
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/139a7755-eafb-4ebc-aaed-dc91e4d7797f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

@httpJunkie httpJunkie added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 13, 2025
Copy link
Contributor

github-actions bot commented Mar 13, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 74a5e85
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28f5dac4-3ed3-4392-bd5f-faf45f6a1d57

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants