-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BSC to supported chains #13964
base: main
Are you sure you want to change the base?
Conversation
- BSC is commented in Production array until ready.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
|
Description
What is the reason for the change?
Smart Transactions are not currently supported on BNB Smart Chain. As part of our effort to expand Smart Transactions functionality to more networks, BSC needs to be added to the list of supported chains.
What is the improvement/solution?
This PR adds BSC to the list of supported chains for Smart Transactions in the mobile app by:
NETWORKS_CHAIN_ID.BSC
toALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_DEVELOPMENT
for testing in development environmentsThese changes allow the app to recognize Base as a valid network for Smart Transactions in development environments, while ensuring we maintain a safe rollout approach for production.
Related issues
Fixes:
TXL-704
Manual testing steps
Since Base isn't fully supported in production yet, this PR implements a phased approach:
Manual testing included:
Screenshots/Recordings
Before
Settings description specifically mentioned Ethereum Mainnet only
After
Settings description is now more generic to accommodate multiple supported networks
Pre-merge author checklist
Pre-merge reviewer checklist