Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(4057): replace asset avatars with network avatars #13910
base: main
Are you sure you want to change the base?
feat(4057): replace asset avatars with network avatars #13910
Changes from all commits
d5508fa
f2ac4e4
5641532
3e47871
675ab11
01a4d95
f741507
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is introduced to optionally avoid rendering the overflow counter to match the Figma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is removed because we are no longer showing the selected network token balance, instead it shows the network avatar icons. See the before and after screenshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer shows the token balance based on selected network. See before and after screenshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This arg is added to allow the opting out of the popular network filter. Going forward we should always show the aggregated balance of each account in the
app/components/UI/AccountSelectorList/AccountSelectorList.tsx
. The network filter should not affect theAccountSelectorList
component and should only affect the token listLarge diffs are not rendered by default.
Unchanged files with check annotations Beta
Check warning on line 54 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 58 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 62 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 94 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 106 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 110 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 121 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 122 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 132 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx
Check warning on line 133 in app/components/UI/Swaps/components/LoadingAnimation/ShapesBackgroundAnimation.tsx